Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 328465 - Tests run with Equinox 3.5
Summary: Tests run with Equinox 3.5
Status: CLOSED WORKSFORME
Alias: None
Product: Virgo
Classification: RT
Component: virgo-build (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-22 08:43 EDT by Hristo Iliev CLA
Modified: 2010-10-22 11:04 EDT (History)
3 users (show)

See Also:

Attachments
Changed OSGI version (3.6.1.R36x_v20100806) (693 bytes, patch)
2010-10-22 10:09 EDT, Hristo Iliev CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hristo Iliev CLA 2010-10-22 08:43:43 EDT 
Build Identifier: 

I noticed in common.properties:
        org.eclipse.osgi.version=3.5.0.v20090311-1300

The value is used in quality.xml in the osgi.init target:
        <ivy:cachepath resolveId="equinox.classpath" pathid="equinox.classpath" organisation="org.eclipse.osgi"
                module="org.eclipse.osgi" revision="${org.eclipse.osgi.version}" type="jar" inline="true"
                log="download-only"/>

This would mean that the tests are running on 3.5 instead of 3.6.


Reproducible: Always
Comment 1 Hristo Iliev CLA 2010-10-22 08:51:37 EDT 
If there is a way to parametrize the Equinox version that would be a good solution.

I'm now experimenting with quality.xml and trying to remove the hardcoded version from there.
Comment 2 Hristo Iliev CLA 2010-10-22 09:39:21 EDT 
If we remove revision from the osgi.init this will result in always using the latest integration version. I'm not sure that's a solution at all.
Comment 3 Hristo Iliev CLA 2010-10-22 10:09:17 EDT 
Created attachment 181498 [details]
Changed OSGI version (3.6.1.R36x_v20100806)
Comment 4 Steve Powell CLA 2010-10-22 10:47:16 EDT 
Hristo,
This version is only used in quality.xml in the target 'osgi.init'
This target is only used in target 'osgi-validate'.

No virgo builds use this target, it is used in EBR updates.  We ought to remove it.

In any case, no build target will pull in the old version of org.eclipse.osgi.version (and if you look in the ivy_cache you will never see it brought in by a clean build).

So this is not an issue, and need not be fixed.  The tests are not running against an old version.
Comment 5 Hristo Iliev CLA 2010-10-22 11:04:33 EDT 
Indeed no 3.5 version is present in the cache. I just started a build to verify this.