328459 – Generate Result dialog allows you to edit Run Log

This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.

Bug 328459 - Generate Result dialog allows you to edit Run Log

Summary: Generate Result dialog allows you to edit Run Log

Status:	RESOLVED FIXED

Alias:	None

Product:	Tigerstripe (Archived)
Classification:	Technology
Component:	UI (show other bugs)
Version:	unspecified
Hardware:	Macintosh Mac OS X - Carbon (unsup.)

Importance:	P3 normal (vote)
Target Milestone:	0.5M0
Assignee:	Daniel Johnson
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2010-10-22 07:52 EDT by Duncan Keysell
Modified:	2010-11-17 20:58 EST (History)
CC List:	2 users (show)

See Also:

Attachments
screenshot of editable text box on dialog (100.40 KB, image/png) 2010-10-22 07:53 EDT, Duncan Keysell	no flags	Details
patch_328459.txt (1.09 KB, patch) 2010-10-26 17:22 EDT, Daniel Johnson	no flags	Details \| Diff
Screenshot (46.41 KB, image/png) 2010-11-17 16:59 EST, Navid Mehregani	no flags	Details
patch_328459.txt (1.09 KB, patch) 2010-11-17 17:39 EST, Daniel Johnson	no flags	Details \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Duncan Keysell

2010-10-22 07:52:17 EDT

When you do a generate in TS it presents you with the "Generate Result" dialog at the end of the generate displaying the Run Log (see screenshot). Currently it is possible to edit the Run Log text box which should not be the case. Also the text box is given the focus which is also annoying.

The text box should be read-only and the OK button should get the focus.

Comment 1 Duncan Keysell

2010-10-22 07:53:57 EDT

Created attachment 181490 [details]
screenshot of editable text box on dialog

Comment 2 Daniel Johnson

2010-10-26 17:22:36 EDT

Created attachment 181787 [details]
patch_328459.txt

Patch to make generate results text box longer editable.
Class Changed: GenerateResultDialog

Comment 3 Navid Mehregani

2010-10-27 19:27:41 EDT

Thanks! Reviewed and submitted.

Comment 4 Navid Mehregani

2010-11-17 16:59:21 EST

Reopening defect, since the text displayed in the generation dialog should be selectable.  User should be able to select and copy it.  It should not be editable.  Also the text no longer seems to be scrollable, which isn't good (see attached screenshot).

Comment 5 Navid Mehregani

2010-11-17 16:59:51 EST

Created attachment 183358 [details]
Screenshot

Comment 6 Daniel Johnson

2010-11-17 17:39:47 EST

Created attachment 183360 [details]
patch_328459.txt

oops, marked it as isEnabled(false) instead of isEditable(false). Now can scroll and copy text correctly.

Comment 7 Navid Mehregani

2010-11-17 20:58:26 EST

Looks good.  Thanks! submitted