Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 328422 - Need IKeyBindingService and INestableKeyBindingService
Summary: Need IKeyBindingService and INestableKeyBindingService
Status: RESOLVED WONTFIX
Alias: None
Product: RAP
Classification: RT
Component: Workbench (show other bugs)
Version: 1.4   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-21 20:39 EDT by Elias Volanakis CLA
Modified: 2010-11-29 04:10 EST (History)
1 user (show)

See Also:

Attachments
patch (12.21 KB, text/plain)
2010-10-21 20:40 EDT, Elias Volanakis CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Elias Volanakis CLA 2010-10-21 20:39:56 EDT 
See patch. Code was already in RAP but commented out.

We need these for single sourcing. They are deprecated _but_ in RCP they are part of a method signature in IWorkbenchPartSite, which we implement.
Comment 1 Elias Volanakis CLA 2010-10-21 20:40:40 EDT 
Created attachment 181458 [details]
patch
Comment 2 Elias Volanakis CLA 2010-10-26 16:48:07 EDT 
Hi Ivan/RAP-team, 

could you review and commit the attached patch? I need it for my project.

Thanks,
Elias.
Comment 3 Ralf Sternberg CLA 2010-10-28 19:06:39 EDT 
(In reply to comment #2)
> could you review and commit the attached patch? I need it for my project.

Usually, we do not incur deprecated code from the platform. The method you refer to on IWorkbenchPartSite is also deprecated. Is there no other way to single-source this?
Comment 4 Elias Volanakis CLA 2010-11-03 12:40:51 EDT 
This one I have to investigate some more.
Comment 5 Ralf Sternberg CLA 2010-11-29 04:10:58 EST 
Closing this bug for now. Elias, if you're still interested, please reopen.