Community
Participate
Working Groups
bug 327607 introduced changes to call IFetchFactory#addTargets when generating a retrieve.xml script to fetch a single feature. This breaks fetch factories that cached information for optimization purposes, in particular the p2 fetch factory. Events go like this: 1) Generate script fetch the entire feature (this is cached) 2) generate a retrieve.xml 1) generate fetch to get feature.xml 2) print targets (clears cache) 3) run script 3) generate fetch for plugins (adds to cache) 4) print targets because the nested retrieve.xml call prints the targets, any cache kept by the fetch factory generally will be cleared here. Then when the main fetch script is continued, the cache is missing the feature and we end up only actually fetching the plugins. The solution is probably to use a separate instance of the fetch factory when generating the nested retrieve.xml
Try to fix this for m3 to avoid the regression
Good catch. It does make sense to use a separate instance for retrieve.xml. Are you working on this or should I create a patch?
I'll do this, it turned into a problem for our e4 git based build
Created attachment 181527 [details] patch This is my patch. One thing I noticed is that the javadoc comment on FetchTaskFactoriesRegsitry#getFactory was wrong, the factories were cached.
released