Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 328279 - Support rendering decorator positioning for connection text decorator
Summary: Support rendering decorator positioning for connection text decorator
Status: CLOSED FIXED
Alias: None
Product: Graphiti
Classification: Modeling
Component: Core (show other bugs)
Version: 0.7.0   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 0.9.0   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard: Juno M4 theme_round_offs
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-20 14:28 EDT by Shenxue Zhou CLA
Modified: 2012-06-29 04:12 EDT (History)
2 users (show)

See Also:
michael.wenz: juno+


Attachments
Proposed solution (3.29 KB, patch)
2011-11-24 05:46 EST, Felix Velasco CLA
no flags Details | Diff
Proposed solution, second edition (3.29 KB, patch)
2011-11-24 06:23 EST, Felix Velasco CLA
matthias.gorning: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Michael Wenz CLA 2011-07-19 03:54:35 EDT
Would like to target for Juno
Comment 2 Michael Wenz CLA 2011-11-23 09:52:44 EST
Just as clarification: What's still missing is a possibility to place the decorator in front of text decorator outside of the actual text GA.
Flagged as enhancement
Comment 3 Felix Velasco CLA 2011-11-24 05:46:42 EST
Created attachment 207470 [details]
Proposed solution

In order to be able to draw outside of the bounds of the decorated figure, I've added the decorating figure to the original figure's parent.

It has some implications on removal, since now the decorating figure isn't contained by the decorating one. Now the decorating figures are explicitly removed in  the deactivate method of the decorated figure.

Also, the real position of the decorated figure is obtained from the constraint in its parent layout instead of its declared bounds, since they are yet not updated.

This allows the decorator to lie outside its owner bounds, not only for text connections, but for any PE.
Comment 4 Felix Velasco CLA 2011-11-24 06:23:06 EST
Created attachment 207474 [details]
Proposed solution, second edition

When adding the decorating figure to the decorated figure's parent, add it just after the decorated one, in order to properly support the z-index.
Comment 5 Matthias Gorning CLA 2011-12-09 04:54:42 EST
@Felix: Thanks for this contribution.

I've committed this patch to the master branch.

commit 91f28cea41d287aaa3848e057769a1518b589a3c
Author: mgorning <matthias.gorning@sap.com> 2011-12-09 10:32:25
Committer: mgorning <matthias.gorning@sap.com> 2011-12-09 10:32:25
Parent: b0bc6abbcf1a95637cc1e2ee55a468d383467466 (Bug 328279 - Support rendering decorator positioning for connection text decorator)
Branches: master
Comment 6 Michael Wenz CLA 2012-04-11 10:43:16 EDT
Bookkeeping: Set target release
Comment 7 Michael Wenz CLA 2012-06-29 04:12:25 EDT
Part of Graphiti 0.9.0 (Eclipse Juno)