Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 328276 - Attribute value proposals cannot filter qualified values
Summary: Attribute value proposals cannot filter qualified values
Status: RESOLVED FIXED
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: wst.html (show other bugs)
Version: 3.2.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2.3   Edit
Assignee: Nick Sandonato CLA
QA Contact: Nick Sandonato CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-20 14:01 EDT by Nick Sandonato CLA
Modified: 2010-12-14 15:41 EST (History)
1 user (show)

See Also:
thatnitind: review+

Attachments
patch (6.61 KB, patch)
2010-10-20 14:08 EDT, Nick Sandonato CLA 		no flags Details | Diff
updated patch (6.72 KB, patch)
2010-10-21 10:31 EDT, Nick Sandonato CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Sandonato CLA 2010-10-20 14:01:15 EDT 
Often times, attribute values may contain some kind of qualified value like "foo.bar.Button". When you have several options like "foo.bar.Button" "foo.bar.Input", "foo.bar.Anchor" and so on. That's a lot of typing if your qualified names are long, when it might be easier to just filter on "Button".
Comment 1 Nick Sandonato CLA 2010-10-20 14:08:16 EDT 
Created attachment 181322 [details]
patch
Comment 2 Nitin Dahyabhai CLA 2010-10-20 17:57:31 EDT 
Looks good, but fAlternateMatch.substring(0, length) could be a problem if the word length is already greater than the alternate match's length.
Comment 3 Nick Sandonato CLA 2010-10-21 10:31:31 EDT 
Created attachment 181398 [details]
updated patch

Ah, nice catch. I also fixed this in the unlikely scenario where if the display string is null, and an alternate match is provided, we'll use it.
Comment 4 Nick Sandonato CLA 2010-12-14 15:41:27 EST 
Thanks for the review.