Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 328224 - [Properties View] Using Edit Service To Edit the properties of Element
Summary: [Properties View] Using Edit Service To Edit the properties of Element
Status: NEW
Alias: None
Product: Papyrus
Classification: Modeling
Component: Core (show other bugs)
Version: 0.7.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 324966
  Show dependency tree
 
Reported: 2010-10-20 05:33 EDT by Vincent Lorenzo CLA
Modified: 2017-09-08 09:55 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vincent Lorenzo CLA 2010-10-20 05:33:28 EDT 
Currently the properties edited in the Property View are modified with a method EObject.eSet(...). We should use the Edit Service, with a SetRequest, to change the value of the properties. 

(These actions are done by the plugin oep.properties.runtime)
Comment 1 Vincent Lorenzo CLA 2010-10-20 10:02:26 EDT 
In r2983 : 
oep.properties.runtime and oep.properties.runtime.uml are modified

Concerning the handlers : 
	- adds a method getSetRequest to IEMFModelHandler
		-> handlers are modified, but this method does nothing for all EMFFeatureStereotypeModelHandler!
	
	- the method getCreateValueOperations is modified in each handler to return a command using the SetRequest
			-> not done for StereotypeHandler
		
Concerning the controllers : 
	- now the handler is owned by EMFTPropertyEditorController and not by EMFTStructuralFeatureController
	- in EMFTPropertyEditorController the method updateModel is modified to use the SetRequest provided by the handler
		 AND its continues to use EMFCommandController, when the handler returns null  (EMFStereotypeModelHandler.getSetRequest() returns null)
	
	- the BeanPropertyCommandHandler are not modified
	
->To be done : 
	modify the stereotype handlers
	modify the BeanPropertyCommandHandler