Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 328220 - use PDE build model API
Summary: use PDE build model API
Status: CLOSED FIXED
Alias: None
Product: MoDisco
Classification: Modeling
Component: Infrastructure (show other bugs)
Version: 0.9.0   Edit
Hardware: PC Windows 7
: P2 normal (vote)
Target Milestone: 0.9.0 M5   Edit
Assignee: Gabriel BARBIER CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-20 05:10 EDT by Nicolas Bros CLA
Modified: 2011-04-28 10:44 EDT (History)
4 users (show)

See Also:
nicolas.bros: indigo+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Bros CLA 2010-10-20 05:10:41 EDT 
org.eclipse.gmt.modisco.infra.common.core.internal.utils.BuildPropertiesUtils#getBuildModel uses internal PDE methods to access the IBuildModel (to view and edit the contents of a build.properties file).

This was done this way, because IPluginModelBase#getBuildModel used to always return null. I created a bug for this API in PDE:
Bug 308623 - IPluginModelBase.getBuildModel() always returns null

Since Eclipse 3.7M2, calling getBuildModel() on IPluginModelBase objects will now return a handle to PDE's build model for that plug-in. 

So, the calls to internal methods should be replaced by this new API.
Comment 1 Gabriel BARBIER CLA 2011-01-03 08:17:56 EST 
Available in revision 3680
Comment 2 Nicolas Bros CLA 2011-01-07 04:30:21 EST 
In fact my first comment was wrong; getBuildModel() still returns null and is now deprecated. PluginRegistry#createBuildModel should be used instead.

Fixed in revision 3688.
Comment 3 Hugo Bruneliere CLA 2011-01-11 05:04:19 EST 
Bug fixed.