Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 328200 - ServerUIPlugin shows server view when the view is not open
Summary: ServerUIPlugin shows server view when the view is not open
Status: RESOLVED FIXED
Alias: None
Product: WTP ServerTools
Classification: WebTools
Component: wst.server (show other bugs)
Version: 3.0.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.0.5 P   Edit
Assignee: Elson Yuen CLA
QA Contact: David Williams CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 328981
  Show dependency tree
 
Reported: 2010-10-19 22:38 EDT by Jason Duan CLA
Modified: 2010-11-03 12:22 EDT (History)
3 users (show)

See Also:
arvera: review+

Attachments
v1.0 (1.30 KB, patch)
2010-10-20 14:51 EDT, Elson Yuen CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Duan CLA 2010-10-19 22:38:52 EDT 
Build Identifier: 3.0.5

In the ServerUIPlugin class, the protected static void showServersView(final boolean bringToFront) method shows the server view when the active page doesn't have the view. 

Reproducible: Always

Steps to Reproduce:
My ref number: 54818
Comment 1 Elson Yuen CLA 2010-10-20 14:48:01 EDT 
Typically, a view should not open itself.  The server preference setting should only bring the view to the front if the view has already been opened.
Comment 2 Elson Yuen CLA 2010-10-20 14:51:19 EDT 
Created attachment 181330 [details]
v1.0

This patch will make the server view to not open by itself. The view will still be brought to the front as needed if the view has already been opened depending on the preference settings.

Testing has been done on the case where the view has already been opened to make sure it brings to the front.  If the view is not opened, then the view will not show by itself.
Comment 3 Elson Yuen CLA 2010-10-28 17:55:04 EDT 
Angel has reviewed this patch already but he just went for vacation.  He'll mark the patch as reviewed when he comes back next Monday.
Comment 4 Carl Anderson CLA 2010-11-03 12:22:10 EDT 
Committed to R3_0_5_patches