Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 328197 - improve query page description if page does not have a refresh button
Summary: improve query page description if page does not have a refresh button
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 trivial (vote)
Target Milestone: 3.5   Edit
Assignee: Steffen Pingel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-19 21:55 EDT by Benjamin Muskalla CLA
Modified: 2011-01-13 23:31 EST (History)
1 user (show)

See Also:

Attachments
mylyn/context/zip (9.52 KB, application/octet-stream)
2010-10-27 05:23 EDT, Steffen Pingel CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Muskalla CLA 2010-10-19 21:55:39 EDT 
AbstractRepositoryQueryPage sets "If attributes are blank or stale press the Update button." as description for the page without any condition. Doesn't make sense under the following conditions:
- setNeedsRepositoryConfiguration(true)
- hasRepositoryConfiguration returns true

In this case, the message is misleading as the update button is not visible.
Comment 1 Steffen Pingel CLA 2010-10-19 23:40:44 EDT 
Good point. Can you provide a patch to fix it?
Comment 2 Steffen Pingel CLA 2010-10-27 05:23:04 EDT 
I have changed the description to "Create a query." if setNeedsRepositoryConfiguration(false) is specified. I believe the message makes sense otherwise as the configuration may have changed in the repository since the last update.
Comment 3 Steffen Pingel CLA 2010-10-27 05:23:07 EDT 
Created attachment 181812 [details]
mylyn/context/zip