Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 328183 - [build][hudson] group test results in junit view
Summary: [build][hudson] group test results in junit view
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 enhancement (vote)
Target Milestone: 0.7   Edit
Assignee: Thomas Ehrnhoefer CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2010-10-19 17:39 EDT by Thomas Ehrnhoefer CLA
Modified: 2011-01-05 14:44 EST (History)
2 users (show)

See Also:

Attachments
patch v1 (2.29 KB, patch)
2010-10-19 19:21 EDT, Thomas Ehrnhoefer CLA 		thomas.ehrnhoefer: review?
Details | Diff
mylyn/context/zip (2.37 KB, application/octet-stream)
2010-10-19 19:21 EDT, Thomas Ehrnhoefer CLA 		no flags Details
patch v2 (5.51 KB, patch)
2010-10-19 20:37 EDT, Thomas Ehrnhoefer CLA 		steffen.pingel: iplog+
thomas.ehrnhoefer: review?
Details | Diff
mylyn/context/zip (7.25 KB, application/octet-stream)
2010-10-19 20:37 EDT, Thomas Ehrnhoefer CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Ehrnhoefer CLA 2010-10-19 17:39:45 EDT 
On big test runs the junit results are one long spaghetti of test cases. Maybe one could add the test suite hierarchy level again to add readability.
Comment 1 Thomas Ehrnhoefer CLA 2010-10-19 18:03:22 EDT 
Turns out they are grouped for a different hudson test build I just connected to. Will investigate further why some test results are not grouped...
Comment 2 Thomas Ehrnhoefer CLA 2010-10-19 19:21:36 EDT 
Created attachment 181233 [details]
patch v1

Ok, it seems some test setups result in a flat hierarchy. Thus for those tests the Junit view will appear flat as well.
This is a tweak of the parsing to introduce the lost level of hierarchy. I am a bit uncertain how robust this will be. I tested it against a test build which appeard hierarchical before, and it still does after applying this patch. And the build I had problems with now also correctly has a test suites hierarchy.
Only information lost is each test suite duration (not for those tests which already had the hierarchy without the patch)

what are your thoughts?
Comment 3 Thomas Ehrnhoefer CLA 2010-10-19 19:21:38 EDT 
Created attachment 181234 [details]
mylyn/context/zip
Comment 4 Steffen Pingel CLA 2010-10-19 20:24:21 EDT 
Patch looks good to me, it's a much better presentation. I am not worried about the duration of the suites, we could calculate it by summing up the grouped cases but I don't think it's important.

Could you adjust the now broken test in JUnitResultGeneratorTest accordingly and add tests for the changes?
Comment 5 Thomas Ehrnhoefer CLA 2010-10-19 20:37:06 EDT 
Created attachment 181240 [details]
patch v2

I guess not checking out the test plugin and thus not breaking any tests locally is not enough, eh?
Comment 6 Thomas Ehrnhoefer CLA 2010-10-19 20:37:07 EDT 
Created attachment 181241 [details]
mylyn/context/zip
Comment 7 Steffen Pingel CLA 2010-10-20 01:41:27 EDT 
Thanks! I have applied the patch.