Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 328093 - EAR Library Directory field should not have preceding slash
Summary: EAR Library Directory field should not have preceding slash
Status: RESOLVED FIXED
Alias: None
Product: WTP Java EE Tools
Classification: WebTools
Component: jst.j2ee (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.0.5 P   Edit
Assignee: Aidyl Kareh CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-19 01:02 EDT by Aidyl Kareh CLA
Modified: 2010-11-03 12:21 EDT (History)
3 users (show)

See Also:
cbridgha: review+
jsholl: review+

Attachments
Proposed Patch (22.67 KB, patch)
2010-10-19 01:07 EDT, Aidyl Kareh CLA 		ccc: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aidyl Kareh CLA 2010-10-19 01:02:29 EDT 
Build Identifier: WTP 3.0.5

The 'New library directory location' field's default behavior in the EAR's 'Java EE Module Dependencies' properties page (click on 'Change Library Directory...' button to access field) has a preceding slash ('/') character by default. This character should not be added to the beginning of the library directory path by default and an error should be shown if the user tries to add it.

Reproducible: Always
Comment 1 Aidyl Kareh CLA 2010-10-19 01:07:59 EDT 
Created attachment 181152 [details]
Proposed Patch

This patch fixes the default behavior of adding a preceding slash to the
library directory field in the 'Java EE Module Dependencies' properties page and also adds validation to avoid having the user add a preceding slash. This patch also adds code so that when comparing the runtime path, which is an absolute path, with the library directory, which should be a relative path, the makeRelative() method is used on both before comparing them.
Comment 2 Chuck Bridgham CLA 2010-10-28 20:09:51 EDT 
approved
Comment 3 Carl Anderson CLA 2010-11-03 12:21:37 EDT 
Committed to R3_0_5_patches