Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 328071 - MySQL OSGi Support
Summary: MySQL OSGi Support
Status: RESOLVED FIXED
Alias: None
Product: Gemini.DBaccess
Classification: RT
Component: Core (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-18 15:48 EDT by Tom Ware CLA
Modified: 2011-12-20 16:44 EST (History)
3 users (show)

See Also:
juergen.kissner: iplog+

Attachments
Initial Changes - without MySQL jdbc driver (27.09 KB, patch)
2010-10-20 10:02 EDT, Tom Ware CLA 		no flags Details | Diff
Updated fix - no PDE project for MySQL driver (23.00 KB, patch)
2010-11-09 14:06 EST, Tom Ware CLA 		michael.keith: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Ware CLA 2010-10-18 15:48:38 EDT 
Please support MySQL.

I will contribute code that is very similar to the Derby Support already in the repository.

We will likely need a CQ for the MySQL DB.
Comment 1 Tom Ware CLA 2010-10-18 15:49:02 EDT 
Correction: We will likely need a CQ for the MySQL JDBC driver.
Comment 2 Tom Ware CLA 2010-10-20 10:02:15 EDT 
Created attachment 181288 [details]
Initial Changes - without MySQL jdbc driver
Comment 3 Tom Ware CLA 2010-11-09 14:06:01 EST 
Created attachment 182752 [details]
Updated fix - no PDE project for MySQL driver
Comment 4 Juergen Kissner CLA 2010-12-17 11:30:25 EST 
I had a look at the attachment:
the current bundle and DBAccess class structure requires quite a bit of code replication with blows up the necessary code. As a side effect the number of lines exceeds 250. If I understand the Eclipse Legal process correctly, I have to file a CQ, because we do not work for the same company (even if both companies have signed the Member Committer agreement). Am I wrong on that?

So I wonder, if we should try and refactor the org.eclipse.gemini.dbaccess bundles before integrating the MySQL contribution.

There are also additional questions about:
- the possible central build
- the tests which, in the current state, would run on Derby only.

What do you think?
Comment 5 Tom Ware CLA 2010-12-17 11:36:23 EST 
There is definitely alot of shared code and the refactor will help alot.

You are correct that for you to check this in there would have to be a CQ.

I spoke to Mike Keith about this and because he and I work for the same company (and that company has signed the Eclipse agreement), no CQ would be required if he checked it in - I was under the impression that he was planning on doing that if it was ok with you.

I am ok with whatever sequence of steps works for you.
Comment 6 Michael Keith CLA 2010-12-17 11:38:34 EST 
Yes, I will check the code into DBAccess SVN if that works for you, Juergen. Then we can do the refactoring at your discretion.
Comment 8 Juergen Kissner CLA 2011-02-27 16:04:12 EST 
Sorry, I was playing with mylyn and muddeled up the Bugs