Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 328064 - AIF cannot handle array of string properly
Summary: AIF cannot handle array of string properly
Status: RESOLVED FIXED
Alias: None
Product: PTP
Classification: Tools
Component: Debug SDM (show other bugs)
Version: 5.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Greg Watson CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-18 14:59 EDT by Xuan Chen CLA
Modified: 2010-10-29 13:06 EDT (History)
0 users

See Also:

Attachments
fix for the problem (949 bytes, text/plain)
2010-10-18 15:00 EDT, Xuan Chen CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xuan Chen CLA 2010-10-18 14:59:49 EDT 
I encountered this problem when I was implementing the Array of String support of X10.

In conv.c, AIFAddArrayElement(), it only treat character pointer (not string) as complex array element, i.e., element with different size.  So I ran into segmentation fault when we try to write those result to the buffer.

If I modify both AIFAddArrayElement() and EmptyArrayToAIF() in conv.c for checking of FDS_STRING type in their if statement, it seems fixed the problem.

Please see attached patch for more information.  Thanks.
Comment 1 Xuan Chen CLA 2010-10-18 15:00:36 EDT 
Created attachment 181121 [details]
fix for the problem
Comment 2 Greg Watson CLA 2010-10-29 13:06:35 EDT 
Committed to 4.0 and HEAD.