328059 – Allow generated retrieve.xml fetch script access to some outside properties

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 328059 - Allow generated retrieve.xml fetch script access to some outside properties

Summary: Allow generated retrieve.xml fetch script access to some outside properties

Status:	RESOLVED FIXED

Alias:	None

Product:	PDE
Classification:	Eclipse Project
Component:	Build (show other bugs)
Version:	3.6
Hardware:	PC Linux

Importance:	P3 enhancement (vote)
Target Milestone:	3.7 M5
Assignee:	pde-build-inbox
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	289838
	Show dependency tree

Reported:	2010-10-18 14:09 EDT by Andrew Niefer
Modified:	2011-01-13 14:46 EST (History)
CC List:	3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Andrew Niefer

2010-10-18 14:09:31 EDT

During fetch script generation a nested ant is run against a generated retrieve.xml to fetch feature.xmls so that we can recursively generated all the fetch scripts.

Currently when running retrieve.xml the only property that is set on this nested ant is the "fetch.failonerror" property.

This is a problem is the fetch factory requires access to anything in the outer build environment.  In particular, GIT wants a repository cache location, thee is no access to even ${buildDirectory}.

Comment 1 Chris Aniszczyk

2010-10-25 18:22:34 EDT

Any idea if this will make 3.7?

Comment 2 Andrew Niefer

2010-10-26 10:00:21 EDT

3.7 yes, but not likely for M3.
Need to decide what properties to pass in, not sure if just inheriting everything is too much.

Comment 3 Andrew Niefer

2010-12-06 13:19:36 EST

I added "buildDirectory" and "fetchCacheLocation" to be passed to the retrieve.xml.  
In order to inherit all we would actually need to enumerate the properties, so for now these two is enough unless there is a need for more

Comment 4 Andrew Niefer

2011-01-13 14:46:52 EST

This somehow got missed being tagged for M4