Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 328044 - Problems in CustomFeaturesJUnitTestSuite
Summary: Problems in CustomFeaturesJUnitTestSuite
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Eclipselink (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-18 10:44 EDT by Andrei Ilitchev CLA
Modified: 2022-06-09 10:03 EDT (History)
0 users

See Also:


Attachments
Suggested patch (15.35 KB, patch)
2010-10-18 10:53 EDT, Andrei Ilitchev CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrei Ilitchev CLA 2010-10-18 10:44:14 EDT
It's a purely test bug.

There is a munch of problems in CustomFeaturesJUnitTestSuite.

1) Reads on the server require active transaction;
2) The cache should be cleared before (not after) read;
3) The em cache should be cleared, too.
Comment 1 Andrei Ilitchev CLA 2010-10-18 10:53:47 EDT
Created attachment 181103 [details]
Suggested patch

After fixing cache clearing it becomes apparent that not all tests work on all versions of Oracle db. That's why Oracle db version is now used.

testNamedStoredProcedureInOutQuery (returning NCHAR as an OUT stored procedure parameter) doesn't work on Oracle db versions before 11.2.0.2.

Test writing xml into the db and then reading it back and comparing with original (testNamedStoredProcedureCursorQuery, testNCharXMLType) require special handling for Oracle db 11.2.0.2

Apparently Oracle db 11.2.0.2 (or at least the instance usd by QA) returns formatted XML, which is not equal to the original one (that may be formmatted differently). The workaround for now is to remove the formatting for the comparison. The solution would be one of the two: 
if formatted xml returned from Oracle 11.2.0.2 db is the bug - then it should be fixed;
if it's a feature, then it should be switched off on the testing db (the suggested way to do that copied from Oracle bug is described in the comment to compare method).
Comment 2 Andrei Ilitchev CLA 2010-10-18 11:58:07 EDT
Checked the patch into trunk. Reviewed by Yiping.
Comment 3 Eclipse Webmaster CLA 2022-06-09 10:03:47 EDT
The Eclipselink project has moved to Github: https://github.com/eclipse-ee4j/eclipselink