Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 327911 - Memory leak in TLDTagRegistry - need to remove preference store listener
Summary: Memory leak in TLDTagRegistry - need to remove preference store listener
Status: RESOLVED FIXED
Alias: None
Product: Java Server Faces
Classification: WebTools
Component: JSF Tools (show other bugs)
Version: 3.2.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2.3   Edit
Assignee: Carlin Rogers CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-15 11:42 EDT by Carlin Rogers CLA
Modified: 2010-10-15 16:12 EDT (History)
1 user (show)

See Also:

Attachments
patch ro remove listener (972 bytes, patch)
2010-10-15 13:08 EDT, Carlin Rogers CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlin Rogers CLA 2010-10-15 11:42:28 EDT 
When the TLDTagRegistry class is disposed, it needs to call removeListener() on the TLDRegistryPreferences so that the reference from the preference store is removed. Should also call dispose on the referenced TLDRegistryPreferences instance so additional memory/resources are released.
Comment 1 Carlin Rogers CLA 2010-10-15 13:08:10 EDT 
Created attachment 180990 [details]
patch ro remove listener
Comment 2 Cameron Bateman CLA 2010-10-15 14:48:48 EDT 
This looks good.
Comment 3 Carlin Rogers CLA 2010-10-15 16:12:26 EDT 
Thanks for the review Cameron. I committed the patch (in HEAD - revision 1.11 of TLDTagRegistry).