Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 327775 - ExternalSettingsProvider does not update existing macros
Summary: ExternalSettingsProvider does not update existing macros
Status: RESOLVED WORKSFORME
Alias: None
Product: CDT
Classification: Tools
Component: cdt-core (show other bugs)
Version: 7.0   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact: Doug Schaefer CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-14 09:34 EDT by Marko Tomljenovic CLA
Modified: 2010-10-15 04:20 EDT (History)
1 user (show)

See Also:

Attachments
Discussion with cdt dev mailing list (7.39 KB, text/plain)
2010-10-14 09:34 EDT, Marko Tomljenovic CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marko Tomljenovic CLA 2010-10-14 09:34:17 EDT 
Created attachment 180877 [details]
Discussion with cdt dev mailing list

When the externalSettingsProvider returns a macro that already exists but now has a different value, the new value is not taken.
Comment 1 James Blackburn CLA 2010-10-14 09:39:00 EDT 
Are you able to add a test?
Comment 2 Marko Tomljenovic CLA 2010-10-15 03:25:47 EDT 
I found the reason for my mentioned problem: 

I have been creating macros like this: new CMacroEntry("name", "value", ICSettingEntry.MACRO). When now updating the value through the ExternalSettingsProvider the new value is not taken, the last one is always kept.

When I create the macros like this: new CMacroEntry("name", "value", 0) then the new value is taken and shown properly.

Although I have used the wrong API calls I would expect another behaviour than what I described (initial value is taken, all newer values not).

I will attach the failing test for that soon.
Comment 3 Marko Tomljenovic CLA 2010-10-15 03:29:56 EDT 
In the trunk the test won't fail so it seems the bug has been fixed there.

I think this issue can be closed.
Comment 4 James Blackburn CLA 2010-10-15 04:20:30 EDT 
Ok, thanks for letting us know.