Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 327723 - [context] add elements to context when a breakpoint is created
Summary: [context] add elements to context when a breakpoint is created
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 enhancement (vote)
Target Milestone: 3.5   Edit
Assignee: Sam Davis CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2010-10-13 20:29 EDT by Sam Davis CLA
Modified: 2012-03-21 12:13 EDT (History)
2 users (show)

See Also:

Attachments
patch (8.39 KB, patch)
2010-11-01 20:13 EDT, Sam Davis CLA 		no flags Details | Diff
mylyn/context/zip (392.80 KB, application/octet-stream)
2010-11-01 20:13 EDT, Sam Davis CLA 		no flags Details
patch (8.62 KB, patch)
2011-01-14 18:13 EST, Sam Davis CLA 		shawn.minto: iplog+
Details | Diff
mylyn/context/zip (23.57 KB, application/octet-stream)
2011-01-14 18:13 EST, Sam Davis CLA 		no flags Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Davis CLA 2010-10-13 20:29:55 EDT 
When I double click in the editor margin to create a breakpoint on a method that is not in my context, the method is not added to my context, so the breakpoint doesn't show up in the filtered breakpoints view. I frequently do this when exploring code. I think adding a breakpoint to a method should cause it to be interesting.
Comment 1 Steffen Pingel CLA 2010-10-13 21:23:07 EDT 
That sounds like a very good idea to me. A patch that makes that work would be very welcome.
Comment 2 Sam Davis CLA 2010-11-01 20:13:37 EDT 
Created attachment 182182 [details]
patch

Here's a patch that fixes this. I wasn't sure how much interest an element should get when a breakpoint is set, but I think it makes sense to give already interesting elements a smaller boost than uninteresting elements.
Comment 3 Sam Davis CLA 2010-11-01 20:13:41 EDT 
Created attachment 182183 [details]
mylyn/context/zip
Comment 4 Sam Davis CLA 2011-01-14 18:13:44 EST 
Created attachment 186862 [details]
patch

Steffen, did you miss this? Updating because after 2 months of it working, I suddenly got a few INVALID_THREAD_ACCESS errors.
Comment 5 Sam Davis CLA 2011-01-14 18:13:46 EST 
Created attachment 186863 [details]
mylyn/context/zip
Comment 6 Steffen Pingel CLA 2011-01-14 18:44:23 EST 
Yes, totally missed the patch. Thanks for bringing this to my attention. I'll try to take a look next week.
Comment 7 Shawn Minto CLA 2011-02-21 14:52:36 EST 
Great work!  I have applied this patch with a couple of changes.  I removed the special interest values and have just made it to be a selection on the element as this seems to make the most sense from the POV of context.  If these elements start dropping out too fast, we could consider adding something similar back.