Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 327690 - WizardHandlers could update the contribution's UI properties
Summary: WizardHandlers could update the contribution's UI properties
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.7   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 enhancement (vote)
Target Milestone: 3.7 M3   Edit
Assignee: Prakash Rangaraj CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-13 13:07 EDT by Prakash Rangaraj CLA
Modified: 2010-10-26 02:54 EDT (History)
2 users (show)

See Also:

Attachments
Patch v01 (2.33 KB, patch)
2010-10-13 13:09 EDT, Prakash Rangaraj CLA 		no flags Details | Diff
Current Contribution items (16.65 KB, image/png)
2010-10-13 13:12 EDT, Prakash Rangaraj CLA 		no flags Details
With Patch applied (18.49 KB, image/png)
2010-10-13 13:13 EDT, Prakash Rangaraj CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Prakash Rangaraj CLA 2010-10-13 13:07:08 EDT 
If we use the commands to populate workbench wizards in the menu/toolbar, the images are not updated. We could use the text/tooltip/icons defined in the wizards to update the contributions
Comment 1 Prakash Rangaraj CLA 2010-10-13 13:09:17 EDT 
Paul,
    Is there any reason why we are not doing this?
Comment 2 Prakash Rangaraj CLA 2010-10-13 13:09:56 EDT 
Created attachment 180794 [details]
Patch v01
Comment 3 Prakash Rangaraj CLA 2010-10-13 13:12:17 EDT 
Created attachment 180795 [details]
Current Contribution items
Comment 4 Prakash Rangaraj CLA 2010-10-13 13:13:21 EDT 
Created attachment 180796 [details]
With Patch applied
Comment 5 Paul Webster CLA 2010-10-13 16:52:16 EDT 
It looks like a good use of the IElementUpdater to me.  It's probably something we haven't got to yet.

Is this not something we could do when creating the CommandContributionItems?

PW
Comment 6 Prakash Rangaraj CLA 2010-10-14 01:29:07 EDT 
(In reply to comment #5)
> Is this not something we could do when creating the CommandContributionItems?

   I don't think so. CCIs are created in the ContributionFactories. They shouldn't be knowing anything about the workbench wizards.
Comment 7 Prakash Rangaraj CLA 2010-10-14 01:34:16 EDT 
Patch v01 released to HEAD
Comment 8 Paul Webster CLA 2010-10-14 09:11:32 EDT 
(In reply to comment #6)
> 
>    I don't think so. CCIs are created in the ContributionFactories. They
> shouldn't be knowing anything about the workbench wizards.

You mean org.eclipse.ui.actions.ContributionItemFactory.NEW_WIZARD_SHORTLIST and org.eclipse.ui.actions.BaseNewWizardMenu ... it doesn't look like BaseNewWizardMenu was converted to commands yet.

In general I think it was a good idea, since this will help a newWizard command + wizardId contributed through org.eclipse.ui.menus.

PW
Comment 9 Prakash Rangaraj CLA 2010-10-15 01:16:51 EDT 
(In reply to comment #8)
> (In reply to comment #6)
> > 
> >    I don't think so. CCIs are created in the ContributionFactories. They
> > shouldn't be knowing anything about the workbench wizards.
> 
> You mean org.eclipse.ui.actions.ContributionItemFactory.NEW_WIZARD_SHORTLIST
> and org.eclipse.ui.actions.BaseNewWizardMenu ... it doesn't look like
> BaseNewWizardMenu was converted to commands yet.

    I was referring to MenuAdditionCacheEntry, where the CCIs are created. I didn't knew a ContributionItemFactory for wizards exist! Will look into it now.
Comment 10 Prakash Rangaraj CLA 2010-10-26 02:54:02 EDT 
Verified in I20101025-1800