Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 327671 - conflicts between adapters for IActionFilter
Summary: conflicts between adapters for IActionFilter
Status: RESOLVED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.6.1   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 312039
  Show dependency tree
 
Reported: 2010-10-13 10:50 EDT by Nicolas Bros CLA
Modified: 2010-10-14 09:28 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Bros CLA 2010-10-13 10:50:46 EDT 
I have a plug-in which registers an adapter on EObject using extension point "org.eclipse.core.runtime.adapters". 
This adapter is used to provide an IActionFilter for EObjects, to filter actions on EObjects in contextual menus.

The problem is that Eclipse seems to take the first adapter it finds. So, if
any installed plug-in also registers an adapter for IActionFilter on EObject as
well, it will conflict with the one I registered.

The filtering mechanism seems to be designed to filter custom elements, that are manipulated by a single plug-in.

But in this case, "EObject" is a common class, that many plug-ins may want to filter on.

I think there should be an extension point to provide IActionFilters, instead of relying on the adapter mechanism.
Comment 1 Paul Webster CLA 2010-10-14 09:28:29 EDT 
We won't update the action extension points or IActionFilter.

Commands and Menu Contributions are based on core expressions, a much more robust and extensible expression syntax.  i.e. in your case you would be providing a property tester with it's own unique namespace to target the properties you want to filter on.

PW