Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 327647 - [Enhancement] Visualizing Inherited Feature
Summary: [Enhancement] Visualizing Inherited Feature
Status: CLOSED FIXED
Alias: None
Product: Papyrus
Classification: Modeling
Component: Core (show other bugs)
Version: 0.7.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 0.7.0   Edit
Assignee: Vincent Lorenzo CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 319238
  Show dependency tree
 
Reported: 2010-10-13 07:36 EDT by Vincent Lorenzo CLA
Modified: 2011-07-11 04:56 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vincent Lorenzo CLA 2010-10-13 07:36:36 EDT 
With the Show/Hide Contents action, we can visualize inherited members in Classifier, but we can easily distinguish the owned feature and the inherited feature.
It could be interesting to precise graphically this information. We have some possibilities : 
	- change the color of the inherited elements
	- change the font of the inherited elements
	- change the style of the border of the inherited elements
	- add an overlay/icon on the inherited elements
	
	- The 2 first possibilities are not possible, because the user can change these properties in the Appearance Tab. 
	- Changing the border style is not very nice, moreover, some elements don't have border (Property in Class Diagram for example)
	- Adding an Icon seems be the most efficient solution. We will implement this solution
Comment 1 Vincent Lorenzo CLA 2010-10-13 07:45:00 EDT 
Done in r2938
	We use a service to add an icon to the inherited elements. The extension point org.eclipse.gmf.runtime.decoratorProvider is used to do that. If the created element (graphical creation) is an Inherited Feature, the decoration provider add an icon (the Generalization icon) next to the elements.
	
	Note : the icon size is 15x15, because 16x16 was too big when we are is a Compartment List.
Comment 2 Vincent Lorenzo CLA 2010-10-13 11:07:49 EDT 
Minor change in r2940
Comment 3 Vincent Lorenzo CLA 2010-10-14 03:33:50 EDT 
r2944, Adds a listener on the Type of the graphical parent (when its a Property), to refresh the display of the decoration
Comment 4 Vincent Lorenzo CLA 2010-10-18 03:03:53 EDT 
in R2959 :
Change the image for the inherited features
Add a specific locator for the affixed child node (OverlayLocator)
Comment 5 Vincent Lorenzo CLA 2010-10-20 11:22:42 EDT 
Minor changes in r2984 and 2985 : all the overlays are now on the bottom left side (excepted in Compartment List, where they are on left side)
Comment 6 Yann Tanguy CLA 2010-10-24 18:54:45 EDT 
The overlay is not correctly updated if the Property is moved.

e.g. In Composite Structure Diagram

Create 2 composite with inheritance
Create a Property in the parent Class
Show the same Property in the child Class (appears with overlay)

Move the Property from Parent to Child Class -> the overlay is not removed from the existing view showing the Property in the child Class.
Comment 7 Vincent Lorenzo CLA 2010-10-25 07:46:45 EDT 
Corrected in r3013.
Comment 8 Vincent Lorenzo CLA 2010-10-26 02:53:18 EDT 
In r3018 : correct a NPE when we do an Undo, after changing the type of a Property
Comment 9 Vincent Lorenzo CLA 2010-10-26 11:32:19 EDT 
In r3020  Re-correct the preceding NPE!
Comment 10 Vincent Lorenzo CLA 2010-11-04 06:43:55 EDT 
In r3112 : 
	adds tests before adding listener on the EObject  (listener is added only for Classifier, Property and Operation)
Comment 11 Vincent Lorenzo CLA 2011-07-11 04:56:13 EDT 
This feature is done. I close the bug.