Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 327607 - Retrieving feature.xml needs to generate fetch factory specific Targets
Summary: Retrieving feature.xml needs to generate fetch factory specific Targets
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: Build (show other bugs)
Version: 3.6   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 3.7 M3   Edit
Assignee: pde-build-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 289838
  Show dependency tree
 
Reported: 2010-10-12 15:48 EDT by Andrew Niefer CLA
Modified: 2010-10-13 10:47 EDT (History)
2 users (show)

See Also:

Attachments
patch (814 bytes, patch)
2010-10-13 10:46 EDT, Andrew Niefer CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Niefer CLA 2010-10-12 15:48:06 EDT 
During fetch script generation, PDE/Build generates a script to fetch the feature.xml and then runs it in a nested ant.

The IFetchFactory interface provides IFetchFactory#addTargets(IAntScript) which allows fetch implementations to generate extra targets that may be needed by individual retrieve element calls.

We generating the nested script to get the feature.xml, we are not calling #addTargets so the resulting script may not work for some fetch factories.
Comment 1 Gunnar Wagenknecht CLA 2010-10-13 03:37:43 EDT 
BTW, the patch in bug 289838 already adds the necessary call to FetchScriptGenerator.
Comment 2 Andrew Niefer CLA 2010-10-13 10:46:16 EDT 
Created attachment 180773 [details]
patch

This is the patch I used, here we are generating a script that fetches one feature.xml there is only one factory involved so we don't need to loop
Comment 3 Andrew Niefer CLA 2010-10-13 10:47:13 EDT 
.