Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 327585 - Commands, Handlers, and keybindings should use leaf lookup
Summary: Commands, Handlers, and keybindings should use leaf lookup
Status: RESOLVED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.1 M3   Edit
Assignee: Paul Webster CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-12 13:00 EDT by Paul Webster CLA
Modified: 2010-10-12 15:07 EDT (History)
2 users (show)

See Also:

Attachments
Use active leaf v01 (4.31 KB, patch)
2010-10-12 13:00 EDT, Paul Webster CLA 		no flags Details | Diff
Allow the eclipse context v01 (1.07 KB, patch)
2010-10-12 13:35 EDT, Paul Webster CLA 		no flags Details | Diff
Use active leaf v02 (22.71 KB, patch)
2010-10-12 14:30 EDT, Paul Webster CLA 		no flags Details | Diff
Updated "Allow the eclipse context v01" (3.36 KB, patch)
2010-10-12 14:30 EDT, Oleg Besedin CLA 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Webster CLA 2010-10-12 13:00:47 EDT 
Created attachment 180689 [details]
Use active leaf v01

The command, handler, and binding service should use the activeLeaf() lookup when it's time to execute.

PW
Comment 1 Paul Webster CLA 2010-10-12 13:35:12 EDT 
Created attachment 180695 [details]
Allow the eclipse context v01

This is a naive implementation.  It simply allows all suppliers to set the IEclispeContext.  In our cases, the primary supplier would set it (since it runs after the temp supplier).

It does allow the temp supplier to set it in the case that primary supplier == null.

Oleg, does this look reasonable?

PW
Comment 2 Paul Webster CLA 2010-10-12 14:30:13 EDT 
Created attachment 180701 [details]
Use active leaf v02

I've included my change to the core.di stuff, but just as a temporary workaround until Oleg can consider the problem.

PW
Comment 3 Oleg Besedin CLA 2010-10-12 14:30:44 EDT 
Created attachment 180702 [details]
Updated "Allow the eclipse context v01"

Very nicely done, I'll change JUnits a bit as well.
Comment 4 Paul Webster CLA 2010-10-12 14:31:37 EDT 
(In reply to comment #2)
> Created an attachment (id=180701) [details]
> Use active leaf v02

I'll hold off on my patch to core.di, then :-)

PW
Comment 5 Paul Webster CLA 2010-10-12 15:07:31 EDT 
Released.  It looks OK, although there may still be some minor compatibility layer work.

PW