Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 327568 - [DataBinding] attributeMaps marked private in ObservableMapCellLabelProvider
Summary: [DataBinding] attributeMaps marked private in ObservableMapCellLabelProvider
Status: RESOLVED DUPLICATE of bug 302860
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.1   Edit
Hardware: All All
: P3 minor (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact: Matthew Hall CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-12 11:06 EDT by Ryan Dunn CLA
Modified: 2010-11-26 14:56 EST (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Dunn CLA 2010-10-12 11:06:45 EDT
Build Identifier: 

The documentation of the class notes "Clients may customize by subclassing and overriding update(ViewerCell)."  But within that method, a subclass would need to access the attributeMaps variable, just as the default update(ViewerCell) method does.  A subclass can create it's own attributeMaps varriable, override the constructor ObservableMapCellLabelProvider(IObservableMap[] attributeMaps), and the dispose() method to get the desired functionality, but that requires overriding two methods that will see no changes in the subclass.

Reproducible: Always
Comment 1 Ryan Dunn CLA 2010-10-12 11:08:22 EDT
(In reply to comment #0)
> Build Identifier: 
> 
> The documentation of the class notes "Clients may customize by subclassing and
> overriding update(ViewerCell)."  But within that method, a subclass would need
> to access the attributeMaps variable, just as the default update(ViewerCell)
> method does.  A subclass can create it's own attributeMaps varriable, override
> the constructor ObservableMapCellLabelProvider(IObservableMap[] attributeMaps),
> and the dispose() method to get the desired functionality, but that requires
> overriding two methods that will see no changes in the subclass.
> 
> Reproducible: Always

I forgot to state the obvious that attributeMaps should be marked protected to resolve this.
Comment 2 Ovidio Mallo CLA 2010-11-26 14:56:14 EST
Ryan, which version of DataBinding are you using? The attributeMaps fields of the ObservableMapCellLabelProvider and ObservableMapLabelProvider classes have already been changed to be protected as part of bug 302860.

*** This bug has been marked as a duplicate of bug 302860 ***