327503 – [Mac] On cocoa, Shell could be decorated with the titlePath property

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 327503 - [Mac] On cocoa, Shell could be decorated with the titlePath property

Summary: [Mac] On cocoa, Shell could be decorated with the titlePath property

Status:	VERIFIED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	3.7
Hardware:	PC Mac OS X

Importance:	P3 enhancement (vote)
Target Milestone:	3.7 M3
Assignee:	Prakash Rangaraj
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2010-10-12 01:55 EDT by Prakash Rangaraj
Modified:	2010-10-26 02:47 EDT (History)
CC List:	1 user (show)

See Also:

Attachments
Patch v01 (27.85 KB, patch) 2010-10-12 01:56 EDT, Prakash Rangaraj	no flags	Details \| Diff
Patch v02 (18.22 KB, patch) 2010-10-14 05:09 EDT, Prakash Rangaraj	no flags	Details \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Prakash Rangaraj

2010-10-12 01:55:40 EDT

Comment 1 Prakash Rangaraj

2010-10-12 01:56:26 EDT

Created attachment 180633 [details]
Patch v01

Patch to address this.

Comment 2 Prakash Rangaraj

2010-10-12 01:57:13 EDT

Patch v01 released to HEAD

Comment 3 Prakash Rangaraj

2010-10-12 01:57:52 EDT

(In reply to comment #2)
> Patch v01 released to HEAD

Comment 4 Prakash Rangaraj

2010-10-12 02:40:42 EDT

Forgot that I had commented out some test code to check this. Reverted the patch for now :-(

Comment 5 Prakash Rangaraj

2010-10-12 03:03:33 EDT

Paul,

   As per TweakletCheckTest, we should remove the tweaklet extensions while testing. How do we disable the extensions for the tests alone?

Comment 6 Paul Webster

2010-10-12 09:05:04 EDT

Prakash, by default our project should only format changed sections.  It looks like a lot of your patch is unchanged code that's been reformatted.  Could you check that for future patches?

Boris, I'm not sure why we added those tests (except that it's possible that some specific tweaklets will kill our tests).

If that's the case, Prakash maybe you could update the test with a set of IDs that *are* allowed.  Scan through the Extensions and abort only if you find an extension that isn't in your approved list.

PW

Comment 7 Prakash Rangaraj

2010-10-14 05:09:13 EDT

Created attachment 180859 [details]
Patch v02

> Prakash, by default our project should only format changed sections.

    This didn't happen because we don't have that setting on the ide project. We have it only on workbench. We should enable that preference on other projects as well
 
> If that's the case, Prakash maybe you could update the test with a set of IDs
> that *are* allowed.  Scan through the Extensions and abort only if you find an
> extension that isn't in your approved list.

    Done that in Patch v02.

    Also, Scott has opened up the methods on NSWindow, so that I don't have to register and call the method. Updated patch accordingly. Scott has also added arrangeInFront. Patch v02 updated with that functionality as well

Comment 8 Prakash Rangaraj

2010-10-14 05:10:36 EDT

Patch v02 released to HEAD

Comment 9 Prakash Rangaraj

2010-10-26 02:47:05 EDT

verified in I20101025-1800