Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 327494 - add IMemory.ErrorOffset RANGE_KEY_XXXX static strings for use by MemoryProxy, etc
Summary: add IMemory.ErrorOffset RANGE_KEY_XXXX static strings for use by MemoryProxy,...
Status: RESOLVED FIXED
Alias: None
Product: TCF
Classification: Tools
Component: Core (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 0.4.0   Edit
Assignee: Project Inbox CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-11 21:18 EDT by Kirk Beitz CLA
Modified: 2013-06-05 07:56 EDT (History)
2 users (show)

See Also:


Attachments
simple patch to supply RANGE_KEY_XXXX strings for use in constructing the ranges passed in IMemory.ErrorOffset reports (2.01 KB, patch)
2010-10-11 21:21 EDT, Kirk Beitz CLA
eugene: iplog+
kirk.beitz: review?
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kirk Beitz CLA 2010-10-11 21:18:15 EDT
Build Identifier: 

private class MemoryProxy.MemoryErrorReport makes use of several strings ("addr", "size", "stat", "msg") in interpreting an error report for getMemory() call where the range may be broken into valid and invalid ranges.

i recommend using static strings for these range keys, of the form RANGE_KEY_ADDR, etc.  this would be in conforming with other static string use in the same interface, and would make it clearer in agents in which such strings are being constructed where the values are coming from, and (using eclipse ctrl-shift-g in the workspace) where they are used so that the proper construction can be made.

Reproducible: Always
Comment 1 Kirk Beitz CLA 2010-10-11 21:21:43 EDT
Created attachment 180628 [details]
simple patch to supply RANGE_KEY_XXXX strings for use in constructing the ranges passed in IMemory.ErrorOffset reports

attached is a simple patch for what i would like to be able to use from TCF
Comment 2 Eugene Tarassov CLA 2010-10-12 19:13:19 EDT
The patch looks fine.
Committed.
Thanks!
Comment 3 Doug Schaefer CLA 2011-05-17 10:48:26 EDT
Moving bugs to new home for IP log.
Comment 4 Martin Oberhuber CLA 2013-06-05 06:25:34 EDT
Bulk change: Marking all bugs from the TM era (until June 2011) target 0.3