Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 327493 - Diagram Save as corrupts the copy
Summary: Diagram Save as corrupts the copy
Status: VERIFIED FIXED
Alias: None
Product: Tigerstripe
Classification: Technology
Component: Diagrams (show other bugs)
Version: 0.5M1   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.5M0   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-11 21:00 EDT by Chris Hartley CLA
Modified: 2010-10-21 13:39 EDT (History)
3 users (show)

See Also:


Attachments
Patch (18.22 KB, patch)
2010-10-20 10:41 EDT, Valentin Yerastov CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Hartley CLA 2010-10-11 21:00:33 EDT
Open a diagram.
Make some changes to it.

Now from the menu choose File SaveAs...
Choose a new name

The new diagram is corrupt.

Throws this error

null
Error
Tue Oct 12 11:25:00 CST 2010
Unhandled event loop exception

java.lang.NullPointerException
at org.eclipse.tigerstripe.workbench.ui.visualeditor.impl.QualifiedNamedElementImpl.getCorrespondingIArtifact(QualifiedNamedElementImpl.java:333)
at org.eclipse.tigerstripe.workbench.ui.visualeditor.diagram.part.PartAdapterFactory.getAnnotable(PartAdapterFactory.java:63)
at org.eclipse.tigerstripe.workbench.ui.visualeditor.diagram.part.PartAdapterFactory.getAdapter(PartAdapterFactory.java:45)
at org.eclipse.core.internal.runtime.AdapterManager.getAdapter(AdapterManager.java:293)
at org.eclipse.gef.editparts.AbstractEditPart.getAdapter(AbstractEditPart.java:435)
at org.eclipse.gef.editparts.AbstractGraphicalEditPart.getAdapter(AbstractGraphicalEditPart.java:426)
at org.eclipse.gmf.runtime.diagram.ui.editparts.GraphicalEditPart.getAdapter(GraphicalEditPart.java:395)
at org.eclipse.tigerstripe.workbench.ui.visualeditor.diagram.edit.parts.AdaptableTigerstripeShapeNodeEditPart.getAdapter(AdaptableTigerstripeShapeNodeEditPart.java:57)
at org.eclipse.tigerstripe.workbench.ui.visualeditor.diagram.edit.parts.AbstractNamePackageEditPart.decorateText(AbstractNamePackageEditPart.java:64)
at org.eclipse.tigerstripe.workbench.ui.visualeditor.diagram.edit.parts.ManagedEntityArtifactNamePackageEditPart.getLabelText(ManagedEntityArtifactNamePackageEditPart.java:274)
at org.eclipse.tigerstripe.workbench.ui.visualeditor.diagram.edit.parts.ManagedEntityArtifactNamePackageEditPart.refreshLabel(ManagedEntityArtifactNamePackageEditPart.java:477)
at org.eclipse.tigerstripe.workbench.ui.visualeditor.diagram.edit.parts.ManagedEntityArtifactNamePackageEditPart.refreshVisuals(ManagedEntityArtifactNamePackageEditPart.java:466)
at org.eclipse.tigerstripe.workbench.ui.visualeditor.diagram.edit.parts.ManagedEntityArtifactNamePackageEditPart.setLabel(ManagedEntityArtifactNamePackageEditPart.java:202)
at org.eclipse.tigerstripe.workbench.ui.visualeditor.diagram.edit.parts.ManagedEntityArtifactEditPart.addFixedChild(ManagedEntityArtifactEditPart.java:177)
at org.eclipse.tigerstripe.workbench.ui.visualeditor.diagram.edit.parts.ManagedEntityArtifactEditPart.addChildVisual(ManagedEntityArtifactEditPart.java:258)
at org.eclipse.gef.editparts.AbstractEditPart.addChild(AbstractEditPart.java:197)
at org.eclipse.gmf.runtime.diagram.ui.editparts.GraphicalEditPart.addChild(GraphicalEditPart.java:1313)
at org.eclipse.gef.editparts.AbstractEditPart.refreshChildren(AbstractEditPart.java:727)
at org.eclipse.gef.editparts.AbstractEditPart.refresh(AbstractEditPart.java:677)
at org.eclipse.gef.editparts.AbstractGraphicalEditPart.refresh(AbstractGraphicalEditPart.java:571)
at org.eclipse.gmf.runtime.diagram.ui.editparts.GraphicalEditPart.access$3(GraphicalEditPart.java:1)
at org.eclipse.gmf.runtime.diagram.ui.editparts.GraphicalEditPart$3.run(GraphicalEditPart.java:855)
at org.eclipse.emf.transaction.impl.TransactionalEditingDomainImpl.runExclusive(TransactionalEditingDomainImpl.java:313)
at org.eclipse.gmf.runtime.diagram.ui.editparts.GraphicalEditPart.refresh(GraphicalEditPart.java:845)
at org.eclipse.gef.editparts.AbstractEditPart.addNotify(AbstractEditPart.java:235)
at org.eclipse.gef.editparts.AbstractGraphicalEditPart.addNotify(AbstractGraphicalEditPart.java:219)
at org.eclipse.gef.editparts.AbstractEditPart.addChild(AbstractEditPart.java:198)
at org.eclipse.gmf.runtime.diagram.ui.editparts.GraphicalEditPart.addChild(GraphicalEditPart.java:1313)
at org.eclipse.gef.editparts.AbstractEditPart.refreshChildren(AbstractEditPart.java:727)
at org.eclipse.gef.editparts.AbstractEditPart.refresh(AbstractEditPart.java:677)
at org.eclipse.gef.editparts.AbstractGraphicalEditPart.refresh(AbstractGraphicalEditPart.java:571)
at org.eclipse.gmf.runtime.diagram.ui.editparts.GraphicalEditPart.access$3(GraphicalEditPart.java:1)
at org.eclipse.gmf.runtime.diagram.ui.editparts.GraphicalEditPart$3.run(GraphicalEditPart.java:855)
at org.eclipse.emf.transaction.impl.TransactionalEditingDomainImpl.runExclusive(TransactionalEditingDomainImpl.java:313)
at org.eclipse.gmf.runtime.diagram.ui.editparts.GraphicalEditPart.refresh(GraphicalEditPart.java:845)
at org.eclipse.tigerstripe.workbench.ui.visualeditor.diagram.edit.parts.MapEditPart.refresh(MapEditPart.java:72)
at org.eclipse.gef.editparts.AbstractEditPart.addNotify(AbstractEditPart.java:235)
at org.eclipse.gef.editparts.AbstractGraphicalEditPart.addNotify(AbstractGraphicalEditPart.java:219)
at org.eclipse.gef.editparts.AbstractEditPart.addChild(AbstractEditPart.java:198)
at org.eclipse.gef.editparts.SimpleRootEditPart.setContents(SimpleRootEditPart.java:101)
at org.eclipse.gef.ui.parts.AbstractEditPartViewer.setContents(AbstractEditPartViewer.java:601)
at org.eclipse.gmf.runtime.diagram.ui.parts.DiagramGraphicalViewer.setContents(DiagramGraphicalViewer.java:378)
at org.eclipse.gef.ui.parts.AbstractEditPartViewer.setContents(AbstractEditPartViewer.java:610)
at org.eclipse.gmf.runtime.diagram.ui.parts.DiagramEditor.initializeGraphicalViewerContents(DiagramEditor.java:870)
at org.eclipse.gmf.runtime.diagram.ui.resources.editor.parts.DiagramDocumentEditor.doSetInput(DiagramDocumentEditor.java:479)
at org.eclipse.gmf.runtime.diagram.ui.resources.editor.parts.DiagramDocumentEditor.setInput(DiagramDocumentEditor.java:423)
at org.eclipse.gmf.runtime.diagram.ui.resources.editor.ide.editor.IDEDiagramDocumentEditor.performSaveAs(IDEDiagramDocumentEditor.java:122)
at org.eclipse.gmf.runtime.diagram.ui.resources.editor.ide.editor.FileDiagramEditor.doSaveAs(FileDiagramEditor.java:44)
at org.eclipse.ui.internal.SaveAsAction.run(SaveAsAction.java:64)
at org.eclipse.jface.action.Action.runWithEvent(Action.java:498)
at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:584)
at org.eclipse.jface.action.ActionContributionItem.access$2(ActionContributionItem.java:501)
at org.eclipse.jface.action.ActionContributionItem$5.handleEvent(ActionContributionItem.java:411)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1003)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3910)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3503)
at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2405)
at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2369)
at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2221)
at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:500)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:493)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:113)
at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:194)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:368)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:559)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:514)
at org.eclipse.equinox.launcher.Main.run(Main.java:1311)
at org.eclipse.equinox.launcher.Main.main(Main.java:1287)
Comment 1 Valentin Yerastov CLA 2010-10-20 10:41:29 EDT
Created attachment 181295 [details]
Patch

Done.
Comment 2 Yuri Strot CLA 2010-10-21 12:09:23 EDT
Verified and applied Valentin's patch.
Comment 3 Navid Mehregani CLA 2010-10-21 13:39:41 EDT
Verified. Thanks!