Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 327369 - EAR Library Directory field should not have preceding slash
Summary: EAR Library Directory field should not have preceding slash
Status: RESOLVED FIXED
Alias: None
Product: WTP Java EE Tools
Classification: WebTools
Component: jst.j2ee (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2.2 P   Edit
Assignee: Aidyl Kareh CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-08 18:30 EDT by Aidyl Kareh CLA
Modified: 2010-10-12 10:06 EDT (History)
3 users (show)

See Also:
cbridgha: review+

Attachments
Proposed Patch (8.96 KB, patch)
2010-10-08 18:39 EDT, Aidyl Kareh CLA 		no flags Details | Diff
Updated Proposed Patch (9.02 KB, patch)
2010-10-11 16:02 EDT, Aidyl Kareh CLA 		ccc: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aidyl Kareh CLA 2010-10-08 18:30:35 EDT 
Build Identifier: WTP 3.2.2

The library directory field's default behavior in the EAR's 'Deployment Assembly' page is to have a preceding slash ('/') character. This character should not be added to the beginning of the library directory path. Also, using the 'Revert' button in the EAR's 'Deployment Assembly' page will not revert the library directory value.

Reproducible: Always
Comment 1 Aidyl Kareh CLA 2010-10-08 18:39:11 EDT 
Created attachment 180527 [details]
Proposed Patch

This patch fixes the default behavior of adding a preceding slash to the library directory field in the 'Deployment Assembly' properties page and also adds validation to avoid having the user add a preceding slash. This patch also fixes the issue where the 'Revert' button wasn't reverting the value of the library directory field.
Comment 2 Chuck Bridgham CLA 2010-10-11 10:20:09 EDT 
I approve, but the hover message should give more details re: the issue, not redirect to another place.   The hover can be several sentences long
Comment 3 Aidyl Kareh CLA 2010-10-11 16:02:44 EDT 
Created attachment 180617 [details]
Updated Proposed Patch

This patch takes Chuck's comments into account and adds more description to the error messages.
Comment 4 Carl Anderson CLA 2010-10-11 17:16:36 EDT 
Committed to R3_2_2_patches
Comment 5 Jason Sholl CLA 2010-10-12 10:06:11 EDT 
checked into 32M and HEAD streams for WTP 3.2.3 and WTP 3.3.