Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 327366 - LazyStackRenderer does not correct shared references of parts if they're hidden
Summary: LazyStackRenderer does not correct shared references of parts if they're hidden
Status: RESOLVED WONTFIX
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 1.0   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 4.1 M3   Edit
Assignee: Remy Suen CLA
QA Contact: Eric Moffatt CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 300742
  Show dependency tree
 
Reported: 2010-10-08 16:49 EDT by Remy Suen CLA
Modified: 2010-10-12 11:00 EDT (History)
0 users

See Also:

Attachments
PartRenderingEngineTests tests patch v1 (7.31 KB, patch)
2010-10-08 17:08 EDT, Remy Suen CLA 		no flags Details | Diff
LazyStackRenderer patch v1 (8.84 KB, patch)
2010-10-08 19:22 EDT, Remy Suen CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2010-10-08 16:49:07 EDT 
The showElementRecursive(MUIElement, List<MUIElement>) method ignores parts with a TBR flag of 'false' and do not have their 'curSharedRef' feature redirected to the placeholder of the newly selected perspective.
Comment 1 Remy Suen CLA 2010-10-08 17:08:57 EDT 
Created attachment 180521 [details]
PartRenderingEngineTests tests patch v1
Comment 2 Remy Suen CLA 2010-10-08 19:22:13 EDT 
Created attachment 180528 [details]
LazyStackRenderer patch v1

Change the LazyStackRenderer to correct child placeholder's referenced elements so that they point back to the right placeholder.
Comment 3 Remy Suen CLA 2010-10-08 19:25:24 EDT 
(In reply to comment #2)
> Created an attachment (id=180528) [details]
> LazyStackRenderer patch v1

Fix and tests released to HEAD.
Comment 4 Remy Suen CLA 2010-10-12 11:00:25 EDT 
This causes a discord in that a part's curSharedRef points to a placeholder that its widget is not actually parented under.
Comment 5 Remy Suen CLA 2010-10-12 11:00:38 EDT 
Patch has been rolled back. Marking as WONTFIX.