Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 327362 - setUrl() call navigates to about:blank prior to real url breaks IEWebHistory
Summary: setUrl() call navigates to about:blank prior to real url breaks IEWebHistory
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.6.2   Edit
Assignee: Grant Gayed CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-08 14:54 EDT by B. Chen CLA
Modified: 2010-10-21 10:12 EDT (History)
4 users (show)

See Also:
Silenio_Quarti: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description B. Chen CLA 2010-10-08 14:54:52 EDT 
Build Identifier: Eclipse 3.6.1

setUrl() API navigates to about:blank first before goes to real url. This breaks WebHistory if application calls setUrl("about:blank") first follow by another call setUrl("another url").

This only failed on IE based WebBrowser.

Propose fix:
IE.java
setUrl()
Change 
if (_getUrl().length() == 0 ) {
to
if (_getUrl().length() == 0 && ABOUT_BLANK.equalsIgnoreCase(url)) {


Reproducible: Always
Comment 1 Grant Gayed CLA 2010-10-18 16:44:43 EDT 
fixed > 20101018
Comment 2 B. Chen CLA 2010-10-20 11:39:49 EDT 
Grant, thanks for fixing this bug ! Could you please port this fix into Eclipse 3.6.2 stream? SWT 3.6.2 will be the version used in our product.
Comment 3 Grant Gayed CLA 2010-10-21 10:00:27 EDT 
Since it's a regression it can be considered for 3.6.2.  Adding Silenio for +1.
Comment 4 Grant Gayed CLA 2010-10-21 10:05:00 EDT 
released to 3.6.2 stream > 20101021