Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 327358 - [variables][vm] "Wait for views to update after every step" preference doesn't always work.
Summary: [variables][vm] "Wait for views to update after every step" preference doesn'...
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug-dsf (show other bugs)
Version: 8.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 8.0   Edit
Assignee: Pawel Piech CLA
QA Contact: Pawel Piech CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-08 14:07 EDT by Pawel Piech CLA
Modified: 2011-05-13 10:58 EDT (History)
1 user (show)

See Also:
pawel.1.piech: review? (Randy.Rohrbach)

Attachments
Fix. (40.10 KB, patch)
2010-10-08 14:07 EDT, Pawel Piech CLA 		cdtdoug: iplog-
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pawel Piech CLA 2010-10-08 14:07:06 EDT 
Created attachment 180509 [details]
Fix.

When using this preference, if I press and hold the step-over key, I see that in my variables views the view updates after every few steps, instead of after every step.  

The faulty part is the logic that calculates how many updates are supposed to be completed after every step.  Instead, I tried a different method, where a view listener waits for the "view updates complete" event from the viewer.  Using this listener in the past was not possible because it would issue multiple such events before the view was actually finished updating.
Comment 1 Pawel Piech CLA 2010-10-08 14:10:39 EDT 
I committed the fix.  Randy, please review.  The fix also cleans up the "update scopes" provisional API which was never used.
Comment 2 CDT Genie CLA 2010-10-08 14:23:02 EDT 
*** cdt cvs genie on behalf of ppiech ***
Bug 327358 - [variables][vm] "Wait for views to update after every step" preference doesn't always work

[-] MultiLevelUpdateHandler.java  http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/ui/viewmodel/update/MultiLevelUpdateHandler.java?root=Tools_Project&view=markup
[*] AbstractCachingVMProvider.java 1.21 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/ui/viewmodel/update/AbstractCachingVMProvider.java?root=Tools_Project&r1=1.20&r2=1.21

[-] VisibleUpdateScope.java  http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/debug/internal/ui/viewmodel/update/provisional/VisibleUpdateScope.java?root=Tools_Project&view=markup
[-] IVMUpdateScope.java  http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/debug/internal/ui/viewmodel/update/provisional/IVMUpdateScope.java?root=Tools_Project&view=markup
[-] AllUpdateScope.java  http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/debug/internal/ui/viewmodel/update/provisional/AllUpdateScope.java?root=Tools_Project&view=markup
[-] ICachingVMProviderExtension.java  http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/debug/internal/ui/viewmodel/update/provisional/ICachingVMProviderExtension.java?root=Tools_Project&view=markup

[-] UpdateScopesContribution.java  http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/debug/internal/ui/viewmodel/actions/UpdateScopesContribution.java?root=Tools_Project&view=markup
[-] UpdateScopesPropertyTester.java  http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/debug/internal/ui/viewmodel/actions/UpdateScopesPropertyTester.java?root=Tools_Project&view=markup

[*] MANIFEST.MF 1.18 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf/org.eclipse.cdt.dsf.ui/META-INF/MANIFEST.MF?root=Tools_Project&r1=1.17&r2=1.18