Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 327296 - Clean up relation between Session and SessionConfig
Summary: Clean up relation between Session and SessionConfig
Status: CLOSED FIXED
Alias: None
Product: EMF
Classification: Modeling
Component: cdo.core (show other bugs)
Version: 4.0   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Caspar D. CLA
QA Contact: Eike Stepper CLA
URL:
Whiteboard: Lighter, Faster and Better
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-08 02:21 EDT by Caspar D. CLA
Modified: 2011-06-23 03:36 EDT (History)
2 users (show)

See Also:
stepper: review+

Attachments
Patch v1 (52.04 KB, text/plain)
2010-10-08 02:21 EDT, Caspar D. CLA 		no flags Details
Patch v2 (61.03 KB, patch)
2010-10-11 02:08 EDT, Caspar D. CLA 		no flags Details | Diff
Patch v3 - ready to be committed (69.37 KB, patch)
2010-10-11 03:02 EDT, Eike Stepper CLA 		no flags Details | Diff
Add-on patch (7.88 KB, patch)
2010-10-18 11:57 EDT, Eike Stepper CLA 		no flags Details | Diff
Add-on patch 2 (9.95 KB, patch)
2010-10-19 12:06 EDT, Eike Stepper CLA 		no flags Details | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Caspar D. CLA 2010-10-08 02:21:27 EDT 
Created attachment 180470 [details]
Patch v1

SessionConfig contains too much state, too much intelligence,
and plays too big a role in failover. The Session should be
able to operate without the SessionConfig after it's been
created, configured, and activated.

This is a spin-off from bug 278181.
Comment 1 Caspar D. CLA 2010-10-11 02:08:34 EDT 
Created attachment 180575 [details]
Patch v2

Updated patch (went out of sync due to recent commits).
Comment 2 Eike Stepper CLA 2010-10-11 03:02:36 EDT 
Created attachment 180578 [details]
Patch v3 - ready to be committed

Must have been an odd task :P

I'm glad that we're now cleaner in this area!
Comment 3 Caspar D. CLA 2010-10-11 03:17:19 EDT 
Committed to HEAD
Comment 4 Eike Stepper CLA 2010-10-18 11:53:51 EDT 
org.eclipse.emf.internal.cdo.session.CDOSessionConfigurationImpl.AuthenticatorImpl is a non-static member class and carries a handle to the session configuration when it is passed to the session.
Comment 5 Eike Stepper CLA 2010-10-18 11:57:46 EDT 
Created attachment 181109 [details]
Add-on patch

Removes the implicit session configuration pointer from the authenticator.
Comment 6 Eike Stepper CLA 2010-10-18 12:00:24 EDT 
Committed add-on patch to HEAD
Comment 7 Eike Stepper CLA 2010-10-19 12:06:48 EDT 
Created attachment 181199 [details]
Add-on patch 2

passiveUpdateEnabled and passiveUpdatesMode have not been transferred from the session config to the session, leading to failures in the offline tests.
Comment 8 Eike Stepper CLA 2010-10-19 12:07:33 EDT 
Committed add-on patch 2 to HEAD
Comment 9 Eike Stepper CLA 2011-06-23 03:36:50 EDT 
Available in R20110608-1407