Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 327276 - EAR Libraries Classpath Container not properly picking up remapped lib folder entries
Summary: EAR Libraries Classpath Container not properly picking up remapped lib folder...
Status: RESOLVED FIXED
Alias: None
Product: WTP Java EE Tools
Classification: WebTools
Component: jst.j2ee (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows Server 2003
: P3 major (vote)
Target Milestone: 3.2.2 P   Edit
Assignee: Jason Sholl CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-07 16:10 EDT by Jason Sholl CLA
Modified: 2010-10-12 10:09 EDT (History)
1 user (show)

See Also:
cbridgha: review+


Attachments
Patch for 3.2.2 (2.69 KB, patch)
2010-10-07 16:11 EDT, Jason Sholl CLA
no flags Details | Diff
updated patch (2.85 KB, patch)
2010-10-08 14:56 EDT, Jason Sholl CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Sholl CLA 2010-10-07 16:10:29 EDT
If a EE5 or EE6 ear has a remapped lib folder, e.g. "foo", EAR libraries are not properly picking up the the classpath entries mapped to that folder.  They only properly pick them up if the entry is proceeded with a '/', e.g. "/foo", but this is not required by the spec.  The fix is to take advantage of the IPath.makeRelative() when doing the comparisons to compute which artifacts are indeed in the ear's remapped lib folder.
Comment 1 Jason Sholl CLA 2010-10-07 16:11:56 EDT
Created attachment 180449 [details]
Patch for 3.2.2
Comment 2 Jason Sholl CLA 2010-10-08 14:56:29 EDT
Created attachment 180512 [details]
updated patch

Updates to handle doing nothing when the user sets the lib dir to be nothing, e.g. <library-directory></library-directory>
Comment 3 Chuck Bridgham CLA 2010-10-08 15:13:40 EDT
approved
Comment 4 Carl Anderson CLA 2010-10-11 17:16:14 EDT
Committed to R3_2_2_patches
Comment 5 Jason Sholl CLA 2010-10-12 10:09:56 EDT
code checked into 32M and HEAD for WP 3.2.3 and 3.3