Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 327250 - [jface] Clicking on file in single-click mode sometimes doesn't open file
Summary: [jface] Clicking on file in single-click mode sometimes doesn't open file
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.7 M4   Edit
Assignee: Dani Megert CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 330341
Blocks:
  Show dependency tree
 
Reported: 2010-10-07 11:19 EDT by Dani Megert CLA
Modified: 2010-12-07 07:05 EST (History)
1 user (show)

See Also:
markus.kell.r: review+

Attachments
Fix (1.43 KB, patch)
2010-10-07 11:31 EDT, Dani Megert CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2010-10-07 11:19:15 EDT 
3.0.

Clicking on file in single-click mode sometimes doing nothing.
Comment 1 Dani Megert CLA 2010-10-07 11:21:48 EDT 
The bug happens when using a combination of keyboard and mouse:

Test Case:
0. set the preference to use single click to open files
1. expand a folder by pressing Numpad_Add
2. click on a file inside that folder
==> nothing happens
Comment 2 Dani Megert CLA 2010-10-07 11:31:27 EDT 
Created attachment 180431 [details]
Fix
Comment 3 Dani Megert CLA 2010-10-07 11:31:49 EDT 
Markus, can you review since this is in a sensitive area? Thanks.
Comment 4 Markus Keller CLA 2010-10-08 05:42:17 EDT 
> 1. expand a folder by pressing Numpad_Add
Arrow_Right has the same effect (for people like me who don't have a numpad...)

> ==> nothing happens
Actually, it selects the item, but doesn't open the editor.

Fix looks good and works fine.
Comment 5 Dani Megert CLA 2010-10-08 06:50:59 EDT 
Thanks Markus!

Fixed in HEAD.
Available in builds >= N20101008-2000.
Comment 6 Dani Megert CLA 2010-10-26 04:49:20 EDT 
Verified in I20101025-1800.
Comment 7 Dani Megert CLA 2010-11-16 07:37:27 EST 
The patch fixed the reported case but introduced another problem due to bug 330341.

Broken Test Case:
1. set single-click mode
2. select a file (it opens - good)
3. hold down 'Ctrl'
4. select another file
5. release 'Ctrl'
6. click in the [+] of a project or folder
==> BUG: file from step 4 gets opened

And here's test case that's broken in 3.6 and with this patch:
1. set single-click mode
2. select a file (it opens - good)
3. hold down 'Ctrl'
4. select another file
5. release 'Ctrl'
7. double click in the [+] of a project or folder
==> BUG: file from step 4 gets opened
Comment 8 Dani Megert CLA 2010-11-16 07:57:02 EST 
Released improved fix to HEAD (OpenStrategy.java rev. 1.21).
Available in builds >= N20101116-2000.
Comment 9 Dani Megert CLA 2010-11-16 07:57:10 EST 
.
Comment 10 Dani Megert CLA 2010-12-07 07:05:50 EST 
Verified all mentioned test cases in I20101206-1800.