Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 327238 - Close All doesn't work when there is a view in the editor stack
Summary: Close All doesn't work when there is a view in the editor stack
Status: RESOLVED WORKSFORME
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 1.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 321864
  Show dependency tree
 
Reported: 2010-10-07 10:21 EDT by John Arthorne CLA
Modified: 2010-11-02 09:10 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Arthorne CLA 2010-10-07 10:21:32 EDT 

    


    


      



        
          Comment 1
        

        
          John Arthorne CLA

        

        
        

        
          2010-10-07 10:23:02 EDT
        

      






Build: 4.1 M2

Open a view and drag it into the editor stack (I used Console)
Open some editors
Hit Ctrl+Shift+W

One editor closes, and then the view becomes active and nothing else is closed. I would expect all editors to close but the view to stay open.

    


    


      



        
          Comment 2
        

        
          Remy Suen CLA

        

        
        

        
          2010-10-07 10:50:38 EDT
        

      






This would be our friendly scenario K from bug 321864.

    


    


      



        
          Comment 3
        

        
          Remy Suen CLA

        

        
        

        
          2010-11-01 15:34:10 EDT
        

      






To be clear, the 'Close All' command is meant to "Close all editors". This behaviour should not change.

We should instead create a new command in 4.x that is mapped to Ctrl+Shift+W (therein removing the binding from the original 'Close All' command in 3.x) that will close all parts within the shared area.

    


    


      



        
          Comment 4
        

        
          John Arthorne CLA

        

        
        

        
          2010-11-01 15:54:44 EDT
        

      






Personally I would be happy if Ctrl+Shift+W continued to close all editors. I don't know how useful a "Close all parts in the shared part area" command would be.

    


    


      



        
          Comment 5
        

        
          Remy Suen CLA

        

        
        

        
          2010-11-01 16:00:46 EDT
        

      






(In reply to comment #1)
> One editor closes, and then the view becomes active and nothing else is closed.
> I would expect all editors to close but the view to stay open.

Mm, looks like I misread your original concern, I'll investigate this to see what's going on here.

    


    


      



        
          Comment 6
        

        
          Remy Suen CLA

        

        
        

        
          2010-11-01 16:04:31 EDT
        

      






I don't think your original concern is a problem anymore, John. I cannot reproduce the bug on I20101029-1118.

    


    


      



        
          Comment 7
        

        
          John Arthorne CLA

        

        
        

        
          2010-11-01 16:13:43 EDT
        

      






Feel free to close then - I don't have a 4.1 build up a the moment.

    


    


      



        
          Comment 8
        

        
          Remy Suen CLA

        

        
        

        
          2010-11-02 09:10:52 EDT
        

      






I tried again on a fresh unzip of I20101029-1118 and could not reproduce the problem. Please do not hesitate to reopen the bug if it happens for you again, John.