Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 327192 - Concurrent access to file while decorating
Summary: Concurrent access to file while decorating
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.7   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.7 M3   Edit
Assignee: Oleg Besedin CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 301223 (view as bug list)
Depends on:
Blocks: 329333 329334 329335
  Show dependency tree
 
Reported: 2010-10-07 04:52 EDT by Szymon Ptaszkiewicz CLA
Modified: 2010-11-03 08:35 EDT (History)
5 users (show)

See Also:


Attachments
Stack for importing thread (2.92 KB, text/plain)
2010-10-07 04:53 EDT, Szymon Ptaszkiewicz CLA
no flags Details
Stack for decorating thread (1.83 KB, text/plain)
2010-10-07 04:54 EDT, Szymon Ptaszkiewicz CLA
no flags Details
Patch v.0.1 (1.84 KB, patch)
2010-10-07 04:57 EDT, Szymon Ptaszkiewicz CLA
ob1.eclipse: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Szymon Ptaszkiewicz CLA 2010-10-07 04:52:23 EDT
The issue came out while working on bug 301223. The problem is that during project set import decorating thread and importing thread are both trying to use the same file. Decorating thread is calling file.getContentDescription() and importing thread is trying to delete this file to make space for incoming file from repository. The file is open because of decorator so delete operation is not successful which results in error during import. Delete operation uses scheduling rule but decorator is not. There should be added simple scheduling rule to decorate operation to prevent concurrent access and error during import.
Comment 1 Szymon Ptaszkiewicz CLA 2010-10-07 04:53:41 EDT
Created attachment 180399 [details]
Stack for importing thread
Comment 2 Szymon Ptaszkiewicz CLA 2010-10-07 04:54:11 EDT
Created attachment 180400 [details]
Stack for decorating thread
Comment 3 Szymon Ptaszkiewicz CLA 2010-10-07 04:57:24 EDT
Created attachment 180401 [details]
Patch v.0.1
Comment 4 Oleg Besedin CLA 2010-10-13 11:04:41 EDT
The patch looks good; applied to CVS Head. 

Szymon, thank you for taking time to figure out the problem and prepare the patch!
Comment 5 Oleg Besedin CLA 2010-10-27 15:11:09 EDT
Verified that the code changes appear in the build I20101026-2000.
Comment 6 Szymon Ptaszkiewicz CLA 2010-11-03 08:31:37 EDT
*** Bug 301223 has been marked as a duplicate of this bug. ***