Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 327173 - Metatype service should support password attribute definition type.
Summary: Metatype service should support password attribute definition type.
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: Compendium (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.7 M4   Edit
Assignee: John Ross CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-07 01:10 EDT by John Ross CLA
Modified: 2010-11-15 17:34 EST (History)
2 users (show)

See Also:

Attachments
Proposed Patch 1 (3.13 KB, patch)
2010-11-11 11:08 EST, John Ross CLA 		tjwatson: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Ross CLA 2010-10-07 01:10:48 EDT 
Build Identifier: 

The metatype service implementation should be updated to support the new password attribute definition type for 4.3.

Reproducible: Always
Comment 1 John Ross CLA 2010-10-07 01:59:19 EDT 
The latest unit tests are also failing due to the new MetaTypeProvider.METATYPE_PID and MetaTypeProvider.METATYPE_FACTORY_PID fields. Need to investigate as part of this bug or another.
Comment 2 Thomas Watson CLA 2010-10-07 08:32:32 EDT 
(In reply to comment #1)
> The latest unit tests are also failing due to the new
> MetaTypeProvider.METATYPE_PID and MetaTypeProvider.METATYPE_FACTORY_PID fields.
> Need to investigate as part of this bug or another.

This is related to bug311128.
Comment 3 John Ross CLA 2010-11-09 22:32:22 EST 
Tom, please assign this to me.
Comment 4 John Ross CLA 2010-11-11 11:08:38 EST 
Created attachment 182908 [details]
Proposed Patch 1

Adds support for the PASSWORD attribute type. Note this patch does not include the patch contents from Bug 329452.
Comment 5 Thomas Watson CLA 2010-11-11 11:23:59 EST 
I will review for M4.  Thanks John!
Comment 6 Thomas Watson CLA 2010-11-15 09:06:10 EST 
Patch released.  Thanks John.

Can you take a look at the usages of org.osgi.service.metatype.AttributeDefinition.STRING in org.eclipse.equinox.ds

I am not sure if something needs to change in there to handle password.
Comment 7 Thomas Watson CLA 2010-11-15 09:06:37 EST 
marking as fixed.
Comment 8 John Ross CLA 2010-11-15 17:21:17 EST 
(In reply to comment #6)
> Patch released.  Thanks John.
> Can you take a look at the usages of
> org.osgi.service.metatype.AttributeDefinition.STRING in org.eclipse.equinox.ds
> I am not sure if something needs to change in there to handle password.

DS will need to be updated to support the new PASSWORD type as well. I'll open up a separate defect for this.
Comment 9 Thomas Watson CLA 2010-11-15 17:34:40 EST 
(In reply to comment #8)
> (In reply to comment #6)
> > Patch released.  Thanks John.
> > Can you take a look at the usages of
> > org.osgi.service.metatype.AttributeDefinition.STRING in org.eclipse.equinox.ds
> > I am not sure if something needs to change in there to handle password.
> 
> DS will need to be updated to support the new PASSWORD type as well. I'll open
> up a separate defect for this.

John, I am not sure OSGi CPEG is aware of this implication to DS.  Can you open an CPEG bug to make sure they track this required change to DS?