Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 327156 - Formatting successive comments can condense them to the same line
Summary: Formatting successive comments can condense them to the same line
Status: RESOLVED FIXED
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: wst.css (show other bugs)
Version: 3.2.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2.3   Edit
Assignee: Nick Sandonato CLA
QA Contact: Nick Sandonato CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-06 15:06 EDT by Nick Sandonato CLA
Modified: 2010-10-19 17:16 EDT (History)
1 user (show)

See Also:
thatnitind: review+

Attachments
patch (4.61 KB, patch)
2010-10-06 15:08 EDT, Nick Sandonato CLA 		no flags Details | Diff
patch (8.35 KB, patch)
2010-10-07 10:37 EDT, Nick Sandonato CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Sandonato CLA 2010-10-06 15:06:29 EDT 
Successive comments can be concatenated onto the same line if they do not exceed the line width. This can cause frustration when the comments formatting is important.

Example:

/*****************************************
* Copyright...
*********/

/****

Version 1.0

******/

Can turn into

/*****************************************
* Copyright...
*********/ /****

Version 1.0

******/
Comment 1 Nick Sandonato CLA 2010-10-06 15:08:32 EDT 
Created attachment 180367 [details]
patch

This patch also makes it so that multiple blank lines will condense to one blank line instead of none.
Comment 2 Nick Sandonato CLA 2010-10-07 10:37:25 EDT 
Created attachment 180428 [details]
patch

Patch needed to include some work from Bug 259154.
Comment 3 Nick Sandonato CLA 2010-10-07 10:40:23 EDT 
Added new unit tests and also had to update some old ones. It appears that the code path would always insert two spaces between a } and /* */ on the same line. Corrected that issue and also fixed the unit tests that accounted for the two spaces.
Comment 4 Nick Sandonato CLA 2010-10-19 17:16:57 EDT 
Changes released to 3_2_Maintenance and HEAD.