Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 327131 - Java and Kdm Inventory Model : facet JavaSourceFile to improve
Summary: Java and Kdm Inventory Model : facet JavaSourceFile to improve
Status: CLOSED FIXED
Alias: None
Product: MoDisco
Classification: Modeling
Component: Technologies (show other bugs)
Version: 0.9.0   Edit
Hardware: PC Windows XP
: P2 normal (vote)
Target Milestone: 0.9.0 M3   Edit
Assignee: Fabien Giquel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-06 11:58 EDT by Fabien Giquel CLA
Modified: 2010-10-21 04:56 EDT (History)
3 users (show)

See Also:
fabien.giquel: indigo+

Attachments
Facet Improvement (7.84 KB, patch)
2010-10-12 10:01 EDT, Nicolas Guyomar CLA 		no flags Details | Diff
Java and Kdm Inventory Model Facet Improvement (3.17 KB, patch)
2010-10-12 11:49 EDT, Nicolas Guyomar CLA 		fabien.giquel: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fabien Giquel CLA 2010-10-06 11:58:19 EDT 
The facet JavaSourceFile must have a condition : .java file extension
It will avoid that every "SourceFile" instance is seen as a "JavaSourceFile".
Comment 1 Fabien Giquel CLA 2010-10-06 11:59:16 EDT 
Very Small modification : moving to P2.
Comment 2 Nicolas Guyomar CLA 2010-10-12 10:01:17 EDT 
Created attachment 180670 [details]
Facet Improvement

Hi,

I created a query "IsJavaSourceFile" to filter non java KDM.SourceFile and added it as a condition on the Facet JavasourceFile

(a) I, Nicolas Guyomar, wrote 100% of the code of the contribution
(b) I have the right to contribute the code to Eclipse
(c) I want to contribute this code under EPL


Regards

Nicolas Guyomar
Comment 3 Fabien Giquel CLA 2010-10-12 11:31:33 EDT 
Hi Nicolas,

a small problem in applying the patch
- GetSouceFilecompilationUnit.java is deleted
- GetSourceFilecompilationUnit.java is modified but does not exist until now

I propose you to keep the 'GetSouceFilecompilationUnit' name for giving another patch with small size and having more clear IP trace. I will rename it to 'GetSourceFilecompilationUnit'.

Fabien.
Comment 4 Nicolas Guyomar CLA 2010-10-12 11:49:48 EDT 
Created attachment 180681 [details]
Java and Kdm Inventory Model Facet Improvement

Fabien, 

Here is a patch with only the creation of a single query to filter Java Source File

Regards

Nicolas
Comment 5 Fabien Giquel CLA 2010-10-12 12:19:46 EDT 
The contribution is less than 250 lines : no CQ.
The patch has been commited into SVN (revision 3316).
Comment 6 Hugo Bruneliere CLA 2010-10-21 04:56:11 EDT 
The patch has been successfully committed.