Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 327130 - [Java Composition] LineComment and BlockComment elements are not managed
Summary: [Java Composition] LineComment and BlockComment elements are not managed
Status: CLOSED FIXED
Alias: None
Product: MoDisco
Classification: Modeling
Component: Technologies (show other bugs)
Version: 0.9.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 0.9.0 M3   Edit
Assignee: Fabien Giquel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-06 11:56 EDT by Nicolas Guyomar CLA
Modified: 2010-10-21 04:55 EDT (History)
3 users (show)

See Also:
fabien.giquel: indigo+

Attachments
Java discoverer modification for comments localization (1.31 KB, patch)
2010-10-06 11:57 EDT, Nicolas Guyomar CLA 		fabien.giquel: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Guyomar CLA 2010-10-06 11:56:26 EDT 
Hi,

LineComment and BlockComment elements are not managed by the MoDisco Java Composition discoverer.

This is due to the JDT not visiting those elements as pointed out in bug 84528.

The attached patch add the LineComment and BlockComment element to the BijectiveMap which is used by the Java Composition discoverer. 

The patch modify the JDTVisitor of the MoDisco Java Discoverer, used by the Composition one

1. I, GUYOMAR Nicolas, and others contributors listed in this bug, authored
100%
of the content
2. I have the rights to donate the content to Eclipse under the EPL
3. I have already provided the filled Employer Consent Forms to the Foundation

Regards

Nicolas Guyomar
Comment 1 Nicolas Guyomar CLA 2010-10-06 11:57:05 EDT 
Created attachment 180346 [details]
Java discoverer modification for comments localization
Comment 2 Fabien Giquel CLA 2010-10-08 06:35:40 EDT 
The modification has been commited into SVN.
Thanks.

Next time, please use the following template for IP confirmations :
"(a) I, XXX, wrote 100% of the code of the conribution
(b) I have the right to contribute the code to Eclipse
(c) I want to contribute this code under EPL"

Fabien.
Comment 3 Hugo Bruneliere CLA 2010-10-21 04:55:49 EDT 
The patch has been successfully committed.