Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 327120 - Need to check whether getTextContent() is null before calling getTextContent().trim()
Summary: Need to check whether getTextContent() is null before calling getTextContent(...
Status: RESOLVED FIXED
Alias: None
Product: Java Server Faces
Classification: WebTools
Component: JSF Tools (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2.3   Edit
Assignee: Ian Trimble CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-06 11:08 EDT by Xiaonan Jiang CLA
Modified: 2011-01-04 15:48 EST (History)
2 users (show)

See Also:

Attachments
fix (5.57 KB, patch)
2010-10-06 11:11 EDT, Xiaonan Jiang CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xiaonan Jiang CLA 2010-10-06 11:08:19 EDT 
Build Identifier: M-3.2.1-20100623085141

There are several places wtp/jsf calls getTextContent().trim() without making sure getTextContent() is not null. 
This causes exceptions when the relevant element is empty. 

Reproducible: Always
Comment 1 Xiaonan Jiang CLA 2010-10-06 11:11:28 EDT 
Created attachment 180340 [details]
fix

Added the necessary null checkings.
Comment 2 Yury Kats CLA 2010-12-01 13:46:12 EST 
Is anything preventing the patch from being applied to 3.2.3? Any other assistance we can offer to help resolve this bug?
Comment 3 Raghunathan Srinivasan CLA 2010-12-01 14:25:04 EST 
Mass update: The JSF Tools team is currently focused on performance and deadlock issues in the product. We plan to address other WTP bugs later this month and will review and checkin the patches soon. Thanks for your contribution and understanding.
-Raghu
Comment 4 Yury Kats CLA 2010-12-01 14:44:47 EST 
Thanks, Raghu. Always glad to see performance improvements in the product!
Do you have specific bug numbers for the work being done currently?
Comment 5 Raghunathan Srinivasan CLA 2010-12-01 17:07:54 EST 
(In reply to comment #4)
> Thanks, Raghu. Always glad to see performance improvements in the product!
> Do you have specific bug numbers for the work being done currently?

Recent fixes include: bug 330976, 330937, 330302 . We are launching bugs as and when we narrow the issues we see in the adopter product to issues in WTP. Hope this helps.
Comment 6 Ian Trimble CLA 2011-01-04 15:48:47 EST 
COmmitted to 3.2.3 and 3.3.0 at 2011/01/04 12:48PM PDT.