Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 327096 - [LTTng] Incorrect compare for LTT_CHANNEL_KERNEL results in drawing more events than intended
Summary: [LTTng] Incorrect compare for LTT_CHANNEL_KERNEL results in drawing more even...
Status: CLOSED WONTFIX
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: LinuxTools (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Francois Chouinard CLA
QA Contact: Francois Chouinard CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 301632
  Show dependency tree
 
Reported: 2010-10-06 08:25 EDT by Thomas Gatterweh CLA
Modified: 2022-01-13 14:53 EST (History)
1 user (show)

See Also:


Attachments
patch file (1.33 KB, patch)
2010-10-06 08:29 EDT, Thomas Gatterweh CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Gatterweh CLA 2010-10-06 08:25:46 EDT
Build Identifier: 0.6.1

In ResourcesBeforeUpdateHandlers.java there are compares in the form

	// According to Ltt, we should not draw anything if the channel
	// is the kernel one
	if (trcEvent.getChannelName().equals(
			Channels.LTT_CHANNEL_KERNEL)) {
		return false;
	} else {

However, because the Channels enumeration is not of type String, these compares are useless and will never behave as the comment implies. Instead, the result of the Channel.getInName() function should be compared.

Reproducible: Always
Comment 1 Thomas Gatterweh CLA 2010-10-06 08:29:07 EDT
Created attachment 180321 [details]
patch file
Comment 2 Patrick Tasse CLA 2013-05-22 14:15:10 EDT
This bug was for Legacy LTTng which is being removed in Linux Tools 2.0.