Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 327033 - Workbench doesn't relayout after a stack disappears
Summary: Workbench doesn't relayout after a stack disappears
Status: VERIFIED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 1.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 4.1 M3   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-05 14:44 EDT by Remy Suen CLA
Modified: 2010-10-26 15:39 EDT (History)
0 users

See Also:

Attachments
Clean up the layout handling (9.22 KB, patch)
2010-10-06 14:07 EDT, Eric Moffatt CLA 		no flags Details | Diff
Updated patch to fix test errors (9.46 KB, patch)
2010-10-06 14:14 EDT, Eric Moffatt CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2010-10-05 14:44:14 EDT 
If you close all the views of a stack, you just get an empty rectangle of space now. Resizing your window will adjust the layout properly. Note that reopening the views don't help, you still have to resize something to force a layout.
Comment 1 Remy Suen CLA 2010-10-06 09:13:55 EDT 
1. Window > Open Perspective > Debug
2. Activate the 'Debug' view.
3. Close the 'Variables' view.
4. Close the 'Breakpoints' view.
5. You have the empty area (as described by comment 0).
6. Try to resize the horizontal sash splitter of the 'Debug' view and the empty space. You will get an NPE. Whenever the mouse hovers over that area, you will get that NPE.

java.lang.NullPointerException
at org.eclipse.e4.ui.workbench.renderers.swt.SashLayout.adjustWeights(SashLayout.java:172)
at org.eclipse.e4.ui.workbench.renderers.swt.SashLayout$2.mouseMove(SashLayout.java:88)
at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:205)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1053)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4066)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3657)
at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$4.run(PartRenderingEngine.java:693)
Comment 2 Eric Moffatt CLA 2010-10-06 14:07:43 EDT 
Created attachment 180360 [details]
Clean up the layout handling
Comment 3 Eric Moffatt CLA 2010-10-06 14:14:17 EDT 
Created attachment 180361 [details]
Updated patch to fix test errors


Fixes 'forceLayout' to handle MWindows (which are MPSC's).
Comment 4 Eric Moffatt CLA 2010-10-06 14:18:36 EDT 
Committed in >20101006. Applied the patch.
Comment 5 Eric Moffatt CLA 2010-10-26 15:39:13 EDT 
Verified in I20101026-0203.