Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 327028 - ProjectDescriptions will reprocess identical JARs for TLDs
Summary: ProjectDescriptions will reprocess identical JARs for TLDs
Status: RESOLVED FIXED
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: jst.jsp (show other bugs)
Version: 3.2.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2.3   Edit
Assignee: Nick Sandonato CLA
QA Contact: Nick Sandonato CLA
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2010-10-05 13:28 EDT by Nick Sandonato CLA
Modified: 2010-10-22 10:32 EDT (History)
1 user (show)

See Also:
thatnitind: review+

Attachments
patch (10.13 KB, patch)
2010-10-20 15:39 EDT, Nick Sandonato CLA 		no flags Details | Diff
updated patch (9.61 KB, patch)
2010-10-21 11:35 EDT, Nick Sandonato CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Sandonato CLA 2010-10-05 13:28:36 EDT 
Several ProjectDescriptions may reference identical JARs each requiring inspection of these JARs on the classpath for TLDs. If we could cache the TLDs identified in relation to the resource they've been extracted from, we could improve the performance when loading the ProjectDescription.
Comment 1 Nick Sandonato CLA 2010-10-20 15:39:25 EDT 
Created attachment 181335 [details]
patch
Comment 2 Nitin Dahyabhai CLA 2010-10-20 18:01:26 EDT 
Does the jar record ever get completely removed with this patch?
Comment 3 Nick Sandonato CLA 2010-10-21 11:35:52 EDT 
Created attachment 181415 [details]
updated patch

You're right. The cached entries were never being removed. This update will remove the entries now.
Comment 4 Nick Sandonato CLA 2010-10-22 10:32:10 EDT 
Released to HEAD and 3_2_Maintenance.