Community
Participate
Working Groups
To support shared views the MarkerSupport has been refactored and now holds some of the controls settings like background and foreground-color. The following tests are broken: MarkerSupportTest.testClearAllMarkers() TextRidgetSharedViewTest.testMandatoryMarkersInSharedViews() The MarkerSupport has a Map internalData that holds the ridgets bg and fg-color. When addMarker is called the current bg-color of the control is saved in the Map to restore it, when the mandatory flag is removed from the ridget. But for some strange reason the bg-color gets overwritten with the mandatory bg-color. It seems like the internalData Map is cleared after the call to addMarker.
Created attachment 180242 [details] Fixes a possible typo in the AbstractSWTWidgetRidget In the AbstractSWTWidgetRidget the calls to MarkerSupport bind and unbind seem to be mixed up.
The MarkerSupportTest creates a MarkerSupport for testing but every Ridget gets its own MarkerSupport from the LNF.
unbindMarkerSupport was called before unbindUIControl where the caching of the visible-state took place. Reordering method-calls fixed the bug.
