Community
Participate
Working Groups
I guess I missed something when I fixed bug 317500. For some reason, the new core label on the process entry is not show. What should happen can be seen in: http://wiki.eclipse.org/CDT/User/NewIn80#Showing_cores_in_Debug_view_labels This works with GDB 7.1 and works for Threads for GDB 7.2 also, but not for processes for GDB 7.2
I found some things that I had missed. 1- In GDBProcesses_7_1#getExecutionData(), I use the procId as a groupId in the IMIProcessDMContext case. This is wrong for GDB 7.2 2- In GDBProcesses_7_0#getDebuggingContext(), I use the procId as a groupId when creating the container in both cases. This is wrong for GDB 7.2 3- In GDBProcesses_7_0#attachDebuggerToProcess(), I use the procId as a groupId when I call createContainerContext() 4- In MIProcesses#getDebuggingContext(), I use the procId as a groupId when creating the container in both cases. This code does not run for GDB 7.2, but should be fixed for consistency 5- In MIProcesses#attachDebuggerToProcess(), I use the procId as a groupId when I call createContainerContext(). This code does not run for GDB 7.2, but should be fixed for consistency
Created attachment 180270 [details] Un-reviewed fix for HEAD I wanted to have this fixed so here is a patch that works. I haven't properly reviewed it to make sure it is sane, but at least it is available. I will have to be (easily) adapted for the 7_0 branch. (In reply to comment #1) > 4- In MIProcesses#getDebuggingContext() > 5- In MIProcesses#attachDebuggerToProcess() I was wrong about those two cases, they are code properly since the groupId is the same as the pId for those versions of GDB.
I don't expect to complete this bug for the next four weeks, so if someone wants to take it, its fine with me.
Created attachment 183573 [details] Fix for HEAD Here is the fix for HEAD. Same solution as before, but I made the class easier to override. Committed to HEAD.
Created attachment 183574 [details] Fix for 7_0 And here is the fix for 7_0. Note that it is not a fix for showing the cores with 7.2, since this feature is new for CDT 8.0. However, the couple of fixes I had missed in GDBProcesses_7_0 do belong in 7_0. Committed to 7_0
Mikhail, you can let me know if you see any issues with this.
*** cdt cvs genie on behalf of mkhouzam *** Bug 326970: [processes] Cores are not shown in the process label using GDB 7.2 [*] GDBProcesses_7_1.java 1.3 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/service/GDBProcesses_7_1.java?root=Tools_Project&r1=1.2&r2=1.3 [*] GDBProcesses_7_0.java 1.28 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/service/GDBProcesses_7_0.java?root=Tools_Project&r1=1.27&r2=1.28
*** cdt cvs genie on behalf of mkhouzam *** Bug 326970: [processes] Missing fixes to handle GDB 7.2 where groupId is no longer the pId [*] GDBProcesses_7_0.java 1.21.2.5 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/service/GDBProcesses_7_0.java?root=Tools_Project&r1=1.21.2.4&r2=1.21.2.5
Looks good to me. Not sure that I have good understanding of the related MI protocol though.
