Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 326969 - [compiler] implement changed precedence among different tsupers
Summary: [compiler] implement changed precedence among different tsupers
Status: VERIFIED FIXED
Alias: None
Product: Objectteams
Classification: Tools
Component: OTJ (show other bugs)
Version: 0.7.1   Edit
Hardware: Other Linux
: P3 normal (vote)
Target Milestone: 0.8 M3   Edit
Assignee: Stephan Herrmann CLA
QA Contact:
URL:
Whiteboard:
Keywords: noteworthy
Depends on:
Blocks:
 
Reported: 2010-10-04 16:06 EDT by Stephan Herrmann CLA
Modified: 2010-11-11 09:40 EST (History)
0 users

See Also:

Attachments
implementation (14.15 KB, patch)
2010-10-04 18:22 EDT, Stephan Herrmann CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Herrmann CLA 2010-10-04 16:06:13 EDT 
Work on bug 326839 revealed an inconsistence in OTJLD §1.5(e)
"Precedence among different supers":

Precendence amond different implicit supers had to be changed to
establish consistency such that a role inherited from an implicit
super team has now precedence over one that is inherited from
an explicit super team.

This needs to be reflected in the compiler and in the expected
results of corresponding tests.
Comment 1 Stephan Herrmann CLA 2010-10-04 18:22:34 EDT 
Created attachment 180215 [details]
implementation

The central changes in this patch are:

- CopyInheritance/TeamModel: if tsupers are incommensurable prefer the
  later copy (assumed to originate from an implicit super team)
  (also fixes comparison by checking name equality)

- HierarchyResolver: reverse the array of tsupers.

New test is testGetImplicitSuperclass_TA2TB2TC2R1().

All other changes are compensations for those clients of getTSuperRoleBindings
where order matters.
Comment 2 Stephan Herrmann CLA 2010-10-04 18:24:23 EDT 
patch has been committed as r932, r933
Comment 3 Stephan Herrmann CLA 2010-10-04 18:55:22 EDT 
Tagging as noteworthy to ensure this will be mentioned in the N&N.
Comment 4 Stephan Herrmann CLA 2010-11-11 09:40:53 EST 
The immediate issue has been verified for 0.8 M3 using build 201011100445

A follow-up is in bug 330002.