Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 326965 - Enhancement request: Add a hot key for the Find/Replace function for the memory views
Summary: Enhancement request: Add a hot key for the Find/Replace function for the memo...
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-memory (show other bugs)
Version: 8.0   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 8.0   Edit
Assignee: Randy Rohrbach CLA
QA Contact: Ted Williams CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-04 15:23 EDT by Andre St. Laurent CLA
Modified: 2011-05-13 10:58 EDT (History)
4 users (show)

See Also:
Randy.Rohrbach: review? (pawel.1.piech)

Attachments
Patch for CTRL/F to bring up the Find/Replace dialog box for the Memory and Memory Browser Views (5.66 KB, text/plain)
2010-10-06 08:20 EDT, Andre St. Laurent CLA 		no flags Details
Standard copyright added (6.08 KB, text/plain)
2010-10-06 10:01 EDT, Andre St. Laurent CLA 		no flags Details
Update patch to put more checking in and use the same property set. (7.57 KB, patch)
2010-10-18 15:25 EDT, Randy Rohrbach CLA 		cdtdoug: iplog-
Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andre St. Laurent CLA 2010-10-04 15:23:32 EDT 
Build Identifier: 

Currently, in order to cause the "Find/Replace Memory" dialog to appear you must use the Memory or Memory Browser view "Find/Replace ..." pull-down menu item.

This request proposes adding a hot key/binding to the "Find/Replace" function, with the most obvious choice being CTRL/F.

Reproducible: Always

Steps to Reproduce:
1. Create and run the project of your choice.
2. Add the Memory or Memory Browser view if not already displayed
3. Use the view pull-down menu to display the "Find/Replace Memory" dialog box; dismiss it.
4. Note that there are no keyboard accelerators to invoke the dialog box.
Comment 1 Pawel Piech CLA 2010-10-05 11:18:10 EDT 
Reassigning to CDT.  The Find action is contributed by the org.eclipse.cdt.debug.ui.memorysearch plugin.
Comment 2 Andre St. Laurent CLA 2010-10-06 08:20:37 EDT 
Created attachment 180320 [details]
Patch for CTRL/F to bring up the Find/Replace dialog box for the Memory and Memory Browser Views

This patch adds the ability for users to quickly pop up the Find/Replace dialog box using CTRL/F when focus is set to the Memory or Memory Browser views.
Comment 3 Pawel Piech CLA 2010-10-06 09:07:33 EDT 
Hi Andre,
Could you add the standard copyright notice to the new file:

/*******************************************************************************
 * Copyright (c) 2010 Wind River Systems and others.
 * All rights reserved. This program and the accompanying materials
 * are made available under the terms of the Eclipse Public License v1.0
 * which accompanies this distribution, and is available at
 * http://www.eclipse.org/legal/epl-v10.html
 *
 * Contributors:
 *     Wind River Systems - initial API and implementation
 *******************************************************************************/
Comment 4 Andre St. Laurent CLA 2010-10-06 10:01:30 EDT 
Created attachment 180331 [details]
Standard copyright added

Standard copyright added.
Comment 5 Randy Rohrbach CLA 2010-10-18 15:23:49 EDT 
I'm taking this one.

Randy
Comment 6 Randy Rohrbach CLA 2010-10-18 15:25:33 EDT 
Created attachment 181124 [details]
Update patch to put more checking in and use the same property set.

Update patch to put more checking in and use the same property set. This makes it so no matter how you bring up the dialog it shows the same content.
Comment 7 Randy Rohrbach CLA 2010-10-18 16:22:54 EDT 
Pawel

   I committed the fix to HEAD for CDT 8.0. Please review the changes.

   Thanks

Randy