Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 326957 - EFSExtensionProvider does not handle URI's correctly
Summary: EFSExtensionProvider does not handle URI's correctly
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-core (show other bugs)
Version: 7.0.1   Edit
Hardware: Macintosh Mac OS X
: P3 normal (vote)
Target Milestone: 7.0.2   Edit
Assignee: Vivian Kong CLA
QA Contact: Doug Schaefer CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-04 14:21 EDT by Greg Watson CLA
Modified: 2011-05-13 10:56 EDT (History)
3 users (show)

See Also:

Attachments
proposed patch for cdt_7_0 (1.38 KB, patch)
2011-01-25 15:02 EST, Vivian Kong CLA 		no flags Details | Diff
patch with JUnit tests (4.07 KB, patch)
2011-01-25 15:53 EST, Vivian Kong CLA 		cdtdoug: iplog-
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Greg Watson CLA 2010-10-04 14:21:03 EDT 
The EFSExtensionProvider#createNewURIFromPath method assumes that the argument URI contains an authority component that is server based (and hence is composed of user-info, host, and port components). However the URI specification provides for authority components that are either server based or registry based, and so will it fail for these latter types of URIs, particularly if the authority contains unquoted characters.
Comment 1 Vivian Kong CLA 2011-01-25 15:02:20 EST 
Created attachment 187564 [details]
proposed patch for cdt_7_0

Trivial fix
Chris can you please review?
Comment 2 Sergey Prigogin CLA 2011-01-25 15:19:53 EST 
It makes sense to add unit tests for this method.
Comment 3 Vivian Kong CLA 2011-01-25 15:53:30 EST 
Created attachment 187574 [details]
patch with JUnit tests

Patch for cdt_7_0 with JUnit tests
Comment 4 Chris Recoskie CLA 2011-01-26 11:51:03 EST 
The patch seems ok to me.  All the tests pass.
Comment 5 Vivian Kong CLA 2011-01-26 15:00:42 EST 
Fixed in cdt_7_0 and HEAD